Bug 204832

Summary: [JSC] Remove m_sharingMode field from JSArrayBufferPrototype and make it plain object
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch saam: review+

Yusuke Suzuki
Reported 2019-12-03 18:56:44 PST
[JSC] Remove m_sharingMode field from JSArrayBufferPrototype and make it plain object
Attachments
Patch (3.77 KB, patch)
2019-12-03 18:57 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (4.53 KB, patch)
2019-12-03 19:10 PST, Yusuke Suzuki 		saam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2019-12-03 18:57:20 PST
Created attachment 384780 [details] Patch
Yusuke Suzuki
Comment 2 2019-12-03 19:10:53 PST
Created attachment 384781 [details] Patch
Saam Barati
Comment 3 2019-12-04 08:19:06 PST
Comment on attachment 384781 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384781&action=review > Source/JavaScriptCore/ChangeLog:8 > + m_sharingMode field is not necessary. Just remove it and make JSArrayBufferPrototype a plain object. What do you mean by a plain object here?
Yusuke Suzuki
Comment 4 2019-12-04 10:37:22 PST
Comment on attachment 384781 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384781&action=review >> Source/JavaScriptCore/ChangeLog:8 >> + m_sharingMode field is not necessary. Just remove it and make JSArrayBufferPrototype a plain object. > > What do you mean by a plain object here? I mean, making the layout same to JSNonFinalObject.
Yusuke Suzuki
Comment 5 2019-12-04 10:39:35 PST
Committed r253113: <https://trac.webkit.org/changeset/253113>
Radar WebKit Bug Importer
Comment 6 2019-12-04 10:40:23 PST
<rdar://problem/57629053>
Note You need to log in before you can comment on or make changes to this bug.