Bug 204723

Summary: [LFC][IFC] Add support for word-spacing property
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch koivisto: review+

Description zalan 2019-11-30 18:37:26 PST
ssia
Comment 1 Radar WebKit Bug Importer 2019-11-30 18:37:47 PST
<rdar://problem/57541871>
Comment 2 zalan 2019-11-30 18:42:36 PST
Created attachment 384564 [details]
Patch
Comment 3 Antti Koivisto 2019-12-01 00:55:17 PST
Comment on attachment 384564 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384564&action=review

No tests enabled?

> Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp:714
> +    itemRunWidth = std::max({ }, itemRunWidth);

I think 0_lu would read better than { }
Comment 4 Antti Koivisto 2019-12-01 00:56:37 PST
Comment on attachment 384564 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384564&action=review

> Source/WebCore/layout/inlineformatting/LineLayoutContext.cpp:50
> +        auto wordSpacing = inlineTextItem.isWhitespace() ? LayoutUnit(inlineTextItem.style().fontCascade().wordSpacing()) : LayoutUnit();

0_lu would work here too
Comment 5 zalan 2019-12-01 07:27:13 PST
Committed r252967: <https://trac.webkit.org/changeset/252967>