Summary: | [LFC][IFC] Add support for word-spacing property | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | zalan <zalan> | ||||
Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
zalan
2019-11-30 18:37:26 PST
Created attachment 384564 [details]
Patch
Comment on attachment 384564 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384564&action=review No tests enabled? > Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp:714 > + itemRunWidth = std::max({ }, itemRunWidth); I think 0_lu would read better than { } Comment on attachment 384564 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384564&action=review > Source/WebCore/layout/inlineformatting/LineLayoutContext.cpp:50 > + auto wordSpacing = inlineTextItem.isWhitespace() ? LayoutUnit(inlineTextItem.style().fontCascade().wordSpacing()) : LayoutUnit(); 0_lu would work here too Committed r252967: <https://trac.webkit.org/changeset/252967> |