Bug 204696

Summary: [CMake] Ninja can't build WebKitQuartzCoreAdditions of AppleWin port
Product: WebKit Reporter: Fujii Hironori <Hironori.Fujii>
Component: WebKit Misc.Assignee: Fujii Hironori <Hironori.Fujii>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, bfulgham, don.olmstead, ews-watchlist, gyuyoung.kim, pvollan, ross.kirsling, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Fujii Hironori 2019-11-29 01:51:10 PST 
[CMake] Ninja can't build WebKitQuartzCoreAdditions of AppleWin port

build error:

> ninja: error: build.ninja:35570: bad $-escape (literal $ must be written as $$)

This $ comes from Source/WebKitLegacy/win/WebKitQuartzCoreAdditions/CMakeLists.txt:

> if (${MSVC_CXX_ARCHITECTURE_ID} STREQUAL "X86")
>     link_directories($(WINDOWSSDKDIR)Lib/$(WINDOWSSDKLIBVERSION)/um/x86)
> else ()
>     link_directories($(WINDOWSSDKDIR)Lib/$(WINDOWSSDKLIBVERSION)/um/x64)
> endif ()
Comment 1 Fujii Hironori 2019-11-29 01:57:46 PST 
Created attachment 384491 [details]
Patch
Comment 2 Fujii Hironori 2019-12-01 18:20:25 PST 
Comment on attachment 384491 [details]
Patch

Clearing flags on attachment: 384491

Committed r252973: <https://trac.webkit.org/changeset/252973>
Comment 3 Fujii Hironori 2019-12-01 18:20:28 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2019-12-01 18:21:18 PST 
<rdar://problem/57547855>