Summary: | [Win] Retrieve all following WM_CHAR events at the beginning of processing WM_KEYDOWN event | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> | ||||||||
Component: | WebKit Misc. | Assignee: | Fujii Hironori <Hironori.Fujii> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | achristensen, bfulgham, don.olmstead, pvollan, ross.kirsling, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 204672, 200558 | ||||||||||
Attachments: |
|
Description
Fujii Hironori
2019-11-28 23:42:23 PST
Created attachment 384481 [details]
Patch
Created attachment 384492 [details]
Patch
Comment on attachment 384492 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384492&action=review > Source/WebKit/ChangeLog:25 > + Test: Covered by existing fast/events/inputText-never-fired-on-keydown-cancel.html and fast/events/keydown-keypress-preventDefault.html Shouldn't there be some update to TestExpectations then? Comment on attachment 384492 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384492&action=review >> Source/WebKit/ChangeLog:25 >> + Test: Covered by existing fast/events/inputText-never-fired-on-keydown-cancel.html and fast/events/keydown-keypress-preventDefault.html > > Shouldn't there be some update to TestExpectations then? No. These tests are failing only for WinCairo WebKit2. Comment on attachment 384492 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384492&action=review >>> Source/WebKit/ChangeLog:25 >>> + Test: Covered by existing fast/events/inputText-never-fired-on-keydown-cancel.html and fast/events/keydown-keypress-preventDefault.html >> >> Shouldn't there be some update to TestExpectations then? > > No. These tests are failing only for WinCairo WebKit2. I mean these test aren’t marked as Failure. Comment on attachment 384492 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384492&action=review r=me but let's change the naming somehow. >>>> Source/WebKit/ChangeLog:25 >>>> + Test: Covered by existing fast/events/inputText-never-fired-on-keydown-cancel.html and fast/events/keydown-keypress-preventDefault.html >>> >>> Shouldn't there be some update to TestExpectations then? >> >> No. These tests are failing only for WinCairo WebKit2. > > I mean these test aren’t marked as Failure. I see. We sure do need a test bot, hehe... > Source/WebKit/Shared/NativeWebKeyboardEvent.h:110 > + Vector<MSG> m_followingCharEvents; I think "pending" might be a better word. (followingCharEvents kind of reads like isFollowingCharEvents with the "is" dropped. "subsequent" might also work if you really want to say "comes after" and not "yet to be processed".) Created attachment 384589 [details]
Patch for landing
Thank you for the review.
* Renamed following → pending
Comment on attachment 384589 [details] Patch for landing Clearing flags on attachment: 384589 Committed r252976: <https://trac.webkit.org/changeset/252976> All reviewed patches have been landed. Closing bug. *** Bug 200558 has been marked as a duplicate of this bug. *** |