Bug 204680

Summary: [LFC][IFC] Vector allocate InlineItemRuns
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch
zalan: review+, commit-queue: commit-queue-
patch none

Description Antti Koivisto 2019-11-28 06:07:01 PST
For performance.
Comment 1 Antti Koivisto 2019-11-28 06:27:45 PST
Created attachment 384452 [details]
patch
Comment 2 Antti Koivisto 2019-11-28 06:35:43 PST
Created attachment 384453 [details]
patch
Comment 3 WebKit Commit Bot 2019-11-28 06:58:25 PST
Comment on attachment 384453 [details]
patch

Rejecting attachment 384453 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 384453, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as commit-queue@webkit.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=384453&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=204680&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 384453 from bug 204680.
Fetching: https://bugs.webkit.org/attachment.cgi?id=384453
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Zalan Bujtas']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 3 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp
Hunk #4 succeeded at 215 (offset 1 line).
Hunk #6 succeeded at 448 with fuzz 2 (offset 25 lines).
Hunk #7 succeeded at 485 (offset 23 lines).
Hunk #8 FAILED at 502.
Hunk #9 succeeded at 529 with fuzz 2 (offset 25 lines).
Hunk #10 FAILED at 548.
Hunk #11 succeeded at 687 with fuzz 1 (offset 54 lines).
Hunk #12 succeeded at 714 (offset 54 lines).
2 out of 12 hunks FAILED -- saving rejects to file Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp.rej
patching file Source/WebCore/layout/inlineformatting/InlineLineBuilder.h
Hunk #3 succeeded at 150 with fuzz 1 (offset 2 lines).
Hunk #4 succeeded at 213 (offset 3 lines).

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Zalan Bujtas']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/13282252
Comment 4 Antti Koivisto 2019-11-28 07:22:13 PST
Created attachment 384456 [details]
patch
Comment 5 WebKit Commit Bot 2019-11-28 08:06:18 PST
Comment on attachment 384456 [details]
patch

Clearing flags on attachment: 384456

Committed r252928: <https://trac.webkit.org/changeset/252928>
Comment 6 WebKit Commit Bot 2019-11-28 08:06:20 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-11-28 08:07:22 PST
<rdar://problem/57521063>