Bug 20468

Summary:

Canvas drawImage() doesn't match current specification

Product:

WebKit

Reporter:

Dirk Schulze <krit>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
drawImage() updated	none
drawImage() update	none
drawImage() update	none
Canvas drawImage	darin: review+

Description Dirk Schulze 2008-08-20 15:47:38 PDT

Canvas drawImage() doesn't match current specification. Negative source and destination-rects are aloud now. 
An INDEX_SIZE_ERR exception is only thrown when sw or sh are zero (like in Firefox).

Comment 1 Dirk Schulze 2008-08-20 15:50:31 PDT

Created attachment 22904 [details]
drawImage() updated

drawImage() matches the specification now and exception are only thrown if sh or sw are zero (like ff).

Could only test it on gtk/cairo.

Comment 2 Dirk Schulze 2008-08-21 04:16:54 PDT

Created attachment 22918 [details]
drawImage() update

added const & to normalizeRect.

Comment 3 Dirk Schulze 2008-08-21 11:16:09 PDT

Created attachment 22921 [details]
drawImage() update

Added more testcases.

Comment 4 Dirk Schulze 2008-08-29 00:20:35 PDT

Created attachment 23066 [details]
Canvas drawImage

Removed pixel tests and added getImageData test.

Comment 5 Darin Adler 2008-08-30 23:56:28 PDT

Comment on attachment 23066 [details]
Canvas drawImage

r=me

Comment 6 Mark Rowe (bdash) 2008-09-02 22:50:17 PDT

Landed in r36043.