Bug 20467

Summary: Should allow 0 (without units) as a time value for durations and delays
Product: WebKit Reporter: Chris Marrin <cmarrin>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Enhancement CC: dino, mitz, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
Patch, including LayoutTest files hyatt: review+

Description Chris Marrin 2008-08-20 15:21:50 PDT
The CSS spec allows '0' without units for length values. WebKit has extended this by allowing the same unitless value for angles. It should also allow the same for time values. A value of '0' should be parsed the same as '0s'.
Comment 1 Chris Marrin 2008-08-20 15:45:58 PDT
Created attachment 22903 [details]
Patch, including LayoutTest files
Comment 2 Dave Hyatt 2008-08-20 15:49:36 PDT
Comment on attachment 22903 [details]
Patch, including LayoutTest files

How odd.  I know I wrote this same patch ages ago (back when I was first doing transitions).  Did I never land it?

r=me
Comment 3 Simon Fraser (smfr) 2008-08-20 16:18:51 PDT
Testcase needs wording changes, and changelog entries have tabs.
Comment 4 mitz 2008-08-20 16:21:13 PDT
(In reply to comment #2)
> (From update of attachment 22903 [details] [edit])
> How odd.  I know I wrote this same patch ages ago (back when I was first doing
> transitions).  Did I never land it?

Weird, I am also almost certain that "0" used to work at some point.
Comment 5 Dean Jackson 2008-08-21 16:35:54 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	A	LayoutTests/css1/units/zero-duration-without-units-expected.txt
	A	LayoutTests/css1/units/zero-duration-without-units.html
	M	WebCore/ChangeLog
	M	WebCore/css/CSSParser.cpp
Committed r35879

Comment 6 Chris Marrin 2008-08-21 16:37:52 PDT
patch committed