Bug 204630

Summary:

Web Inspector: REGRESSION(r242604): Console: unread indicator overlaps selection background of previous scope bar item

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, hi, inspector-bugzilla-changes, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

205105

Attachments:

Description	Flags
[Image] Screenshot of issue	none
Patch	none
[Image] After Patch is applied	none
Patch	none
Patch	none

Devin Rousso

Reported 2019-11-26 15:26:55 PST

Created attachment 384384 [details] [Image] Screenshot of issue See attached screenshot.

Attachments
[Image] Screenshot of issue (14.94 KB, image/png) 2019-11-26 15:26 PST, Devin Rousso	no flags	Details
Patch (17.21 KB, patch) 2019-11-28 00:46 PST, Devin Rousso	no flags	Details Formatted Diff Diff
[Image] After Patch is applied (502.97 KB, image/png) 2019-11-28 00:46 PST, Devin Rousso	no flags	Details
Patch (17.32 KB, patch) 2019-11-28 00:50 PST, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (17.28 KB, patch) 2019-12-05 14:10 PST, Devin Rousso	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Devin Rousso

Comment 1 2019-11-28 00:46:08 PST

Created attachment 384442 [details] Patch

Devin Rousso

Comment 2 2019-11-28 00:46:27 PST

Created attachment 384443 [details] [Image] After Patch is applied

Devin Rousso

Comment 3 2019-11-28 00:50:05 PST

Created attachment 384444 [details] Patch Fix logic for when the repeat count of a message is updated

WebKit Commit Bot

Comment 4 2019-12-05 12:17:32 PST Comment hidden (obsolete)

Comment on attachment 384444 [details] Patch Rejecting attachment 384444 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 384444, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=384444&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=204630&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 384444 from bug 204630. Fetching: https://bugs.webkit.org/attachment.cgi?id=384444 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Timothy Hatcher']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 5 diffs from patch file(s). patching file Source/WebInspectorUI/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js Hunk #1 succeeded at 594 (offset 7 lines). Hunk #2 succeeded at 1162 (offset 7 lines). patching file Source/WebInspectorUI/UserInterface/Views/FindBanner.js patching file Source/WebInspectorUI/UserInterface/Views/LogContentView.css patching file Source/WebInspectorUI/UserInterface/Views/LogContentView.js Hunk #6 FAILED at 824. 1 out of 10 hunks FAILED -- saving rejects to file Source/WebInspectorUI/UserInterface/Views/LogContentView.js.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Timothy Hatcher']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/13287072

Devin Rousso

Comment 5 2019-12-05 14:10:38 PST

Created attachment 384946 [details] Patch

WebKit Commit Bot

Comment 6 2019-12-05 14:55:55 PST

Comment on attachment 384946 [details] Patch Clearing flags on attachment: 384946 Committed r253173: <https://trac.webkit.org/changeset/253173>

WebKit Commit Bot

Comment 7 2019-12-05 14:55:57 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 8 2019-12-05 14:56:19 PST

<rdar://problem/57678565>

Note You need to log in before you can comment on or make changes to this bug.