| Summary: | Remove own toString from NativeError prototype | ||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Gus Caplan <me> | ||||||||||||||||||||||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||||||||
| Severity: | Normal | CC: | commit-queue, darin, ews-watchlist, keith_miller, ljharb, mark.lam, msaboff, ross.kirsling, sbarati, tzagallo, webkit-bug-importer, ysuzuki | ||||||||||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||||||
|
Description
Gus Caplan
2019-11-26 14:42:39 PST
Created attachment 384381 [details]
Patch
Created attachment 384383 [details]
Patch
It seems with the current patch, Error.prototype.toString isn't being created anymore. I admittedly have no idea how any of this works, so pointers would be appreciated. Comment on attachment 384383 [details] Patch Attachment 384383 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/13280265 Number of test failures exceeded the failure limit. Created attachment 384385 [details]
Archive of layout-test-results from ews210 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews210 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Created attachment 384397 [details]
Patch
Comment on attachment 384397 [details] Patch Attachment 384397 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/13280748 New failing tests: http/tests/security/regress-52192.html Created attachment 384405 [details]
Archive of layout-test-results from ews210 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews210 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Created attachment 384415 [details]
Patch
Comment on attachment 384415 [details] Patch Attachment 384415 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/13281401 New failing tests: http/tests/security/regress-52192.html Created attachment 384418 [details]
Archive of layout-test-results from ews210 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews210 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Created attachment 384476 [details]
Patch
Created attachment 384526 [details]
Patch
Comment on attachment 384526 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384526&action=review r=me, though you'll need to regenerate the ChangeLogs. > JSTests/stress/nativeerror-prototype-tostring.js:7 > + if (NativeError.prototype.hasOwnProperty('toString')) { > + throw new Error(`${NativeError.name}.prototype should not have own property 'toString'`); > + } Nit: WK style drops braces for one-line conditionals (https://webkit.org/code-style-guidelines/#braces-one-line). I guess the checker ignores JS stress tests but we ought to align anyway. Created attachment 388198 [details]
Patch
Comment on attachment 388198 [details]
Patch
Code change looks pretty good. Need to fix the failing tests on EWS before we get this reviewed.
Comment on attachment 388198 [details]
Patch
The EWS failure here is just due to auto-trimmed whitespace; just need to undo that and get the regenerated changelogs into the patch. :)
Created attachment 388258 [details]
patch
Created attachment 388259 [details]
Patch
The commit-queue encountered the following flaky tests while processing attachment 388259 [details]: editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org) The commit-queue is continuing to process your patch. Comment on attachment 388259 [details] Patch Clearing flags on attachment: 388259 Committed r254842: <https://trac.webkit.org/changeset/254842> All reviewed patches have been landed. Closing bug. |