Bug 204609

Summary:

Web Inspector: Experimental setting for "New Tab" tab is inverted

Product:

WebKit

Reporter:

Philippe Normand <pnormand>

Component:

Web Inspector

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

bugs-noreply, hi, inspector-bugzilla-changes, joepeck

Priority:

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

See Also:

https://bugs.webkit.org/show_bug.cgi?id=204627

Attachments:

Description	Flags
Setting disabled, "+" tab visible	none
Setting enabled, "+" tab hidden	none

Philippe Normand

Reported 2019-11-26 03:34:46 PST

Something's wrong with the experimental setting for "New Tab" ('+' icon). Unsetting it actually enables the tab and setting it disables the tab...

Attachments
Setting disabled, "+" tab visible (19.25 KB, image/png) 2020-01-12 10:39 PST, Philippe Normand	no flags	Details
Setting enabled, "+" tab hidden (17.91 KB, image/png) 2020-01-12 10:40 PST, Philippe Normand	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Philippe Normand

Comment 1 2019-12-25 13:38:56 PST

Also happens with the mac port.

Joseph Pecoraro

Comment 2 2020-01-06 13:57:24 PST

Hmm, there is no experimental setting for "New Tab", only "Enable New Tab Bar" which produces a "?" icon in the tab bar for the search field. Could you add a screenshot for what you are seeing?

Devin Rousso

Comment 3 2020-01-06 14:09:56 PST

FYI, if/when <https://webkit.org/b/204627> lands, this UI will be removed.

Philippe Normand

Comment 4 2020-01-12 10:39:40 PST

Created attachment 387475 [details] Setting disabled, "+" tab visible the "Enable New Tab Bar" setting is unticked, but the "+" tab is visible, isn't it inconsistent?

Philippe Normand

Comment 5 2020-01-12 10:40:18 PST

Created attachment 387476 [details] Setting enabled, "+" tab hidden

Philippe Normand

Comment 6 2020-01-12 10:43:53 PST

I suppose I misunderstood the meaning of that setting :) But I still wonder why the "+" tab gets hidden then, how am I supposed to add new tabs then?

Philippe Normand

Comment 7 2020-05-31 07:39:48 PDT

(In reply to Devin Rousso from comment #3) > FYI, if/when <https://webkit.org/b/204627> lands, this UI will be removed. this landed.

Note You need to log in before you can comment on or make changes to this bug.