Bug 204606

Summary: Update RealtimeOutgoingAudioSourceCocoa::m_writeCount when sampleRate changes
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description youenn fablet 2019-11-26 01:49:10 PST
Update RealtimeOutgoingAudioSourceCocoa::m_writeCount when sampleRate changes
Comment 1 youenn fablet 2019-11-26 01:53:43 PST
<rdar://problem/57458377>
Comment 2 youenn fablet 2019-11-26 01:55:14 PST
Created attachment 384340 [details]
Patch
Comment 3 youenn fablet 2019-11-26 04:06:12 PST
Created attachment 384344 [details]
Patch
Comment 4 WebKit Commit Bot 2019-11-30 04:33:12 PST
Comment on attachment 384344 [details]
Patch

Rejecting attachment 384344 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 384344, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as commit-queue@webkit.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=384344&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=204606&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Updating working directory
Processing patch 384344 from bug 204606.
Fetching: https://bugs.webkit.org/attachment.cgi?id=384344
Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	A	LayoutTests/webrtc/audio-samplerate-change-expected.txt
	A	LayoutTests/webrtc/audio-samplerate-change.html
	M	LayoutTests/ChangeLog
	M	Source/WebCore/ChangeLog

ERROR from SVN:
Item is out of date: File '/trunk/Source/WebCore/ChangeLog' is out of date
W: b50ac7ad22a1601263b2e6a76c0f76f06a98e4f4 and refs/remotes/origin/master differ, using rebase:
:040000 040000 252a033a468729d2a4cba2b4bea2843fcc7e87bf e32963289241e2e734500ccce02eb21f319f4c5a M	LayoutTests
:040000 040000 bbf7ed0cfaca09afd02fc2e36bf781acef9fcd06 2ac7b3a85c81582e45ee20f05636bd0d1a0bf33c M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	A	LayoutTests/webrtc/audio-samplerate-change-expected.txt
	A	LayoutTests/webrtc/audio-samplerate-change.html
	M	LayoutTests/ChangeLog
	M	Source/WebCore/ChangeLog

ERROR from SVN:
Item is out of date: File '/trunk/Source/WebCore/ChangeLog' is out of date
W: b50ac7ad22a1601263b2e6a76c0f76f06a98e4f4 and refs/remotes/origin/master differ, using rebase:
:040000 040000 252a033a468729d2a4cba2b4bea2843fcc7e87bf e32963289241e2e734500ccce02eb21f319f4c5a M	LayoutTests
:040000 040000 bbf7ed0cfaca09afd02fc2e36bf781acef9fcd06 2ac7b3a85c81582e45ee20f05636bd0d1a0bf33c M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
Current branch master is up to date.

Full output: https://webkit-queues.webkit.org/results/13283530
Comment 5 WebKit Commit Bot 2019-11-30 11:07:38 PST
Comment on attachment 384344 [details]
Patch

Clearing flags on attachment: 384344

Committed r252960: <https://trac.webkit.org/changeset/252960>
Comment 6 WebKit Commit Bot 2019-11-30 11:07:40 PST
All reviewed patches have been landed.  Closing bug.