Bug 204594

Summary: [LFC][IFC] Use FontCascade::spaceWidth to measure single or collapsed whitespace content
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

alan
Reported 2019-11-25 14:52:49 PST
ssia
Attachments
Patch (3.06 KB, patch)
2019-11-25 14:54 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (3.06 KB, patch)
2019-11-25 15:44 PST, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-11-25 14:53:13 PST
<rdar://problem/57478360>
alan
Comment 2 2019-11-25 14:54:38 PST
Created attachment 384318 [details] Patch
Antti Koivisto
Comment 3 2019-11-25 15:02:12 PST
Comment on attachment 384318 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384318&action=review > Source/WebCore/layout/inlineformatting/InlineTextItem.cpp:118 > + auto width = simpleSingleWhitespaceContent ? Optional<LayoutUnit>(LayoutUnit { font.spaceWidth() }) : inlineItemWidth(currentPosition, length); Shorter: makeOptional(LayoutUnit { font.spaceWidth() })
alan
Comment 4 2019-11-25 15:44:20 PST
Created attachment 384319 [details] Patch
WebKit Commit Bot
Comment 5 2019-11-25 16:28:25 PST
Comment on attachment 384319 [details] Patch Clearing flags on attachment: 384319 Committed r252869: <https://trac.webkit.org/changeset/252869>
WebKit Commit Bot
Comment 6 2019-11-25 16:28:27 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.