Bug 204593

Summary:

Document::needsStyleRecalc() shouldn't return true for fragment scrolling (m_gotoAnchorNeededAfterStylesheetsLoad)

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

Layout and Rendering

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, cdumez, commit-queue, dbates, esprehn+autocc, ews-watchlist, kangil.han, koivisto, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh, zalan

Priority:

Keywords:

InRadar

Version:

Safari 12

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

203982

Bug Blocks:

Attachments:

Description	Flags
Removes the code	none

Description Ryosuke Niwa 2019-11-25 14:14:14 PST

After https://trac.webkit.org/r252761, fragment scrolling doesn't depend on style resolution.
Consequently, there is no need for Document::needsStyleRecalc() to return true
even when m_gotoAnchorNeededAfterStylesheetsLoad is set and there are no more pending stylesheets.

Comment 1 Ryosuke Niwa 2019-11-25 14:17:28 PST

Created attachment 384317 [details]
Removes the code

Comment 2 Ryosuke Niwa 2019-11-26 01:53:09 PST

Comment on attachment 384317 [details]
Removes the code

Nice! Let’s land this.

Comment 3 WebKit Commit Bot 2019-11-26 02:37:50 PST

Comment on attachment 384317 [details]
Removes the code

Clearing flags on attachment: 384317

Committed r252881: <https://trac.webkit.org/changeset/252881>

Comment 4 WebKit Commit Bot 2019-11-26 02:37:52 PST

All reviewed patches have been landed.  Closing bug.

Comment 5 Radar WebKit Bug Importer 2019-11-26 02:38:21 PST

<rdar://problem/57487005>