Summary: | [css-grid] Exclude implicit tracks from grid-template-rows/columns resolved values | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Oriol Brufau <obrufau> | ||||||
Component: | CSS | Assignee: | Oriol Brufau <obrufau> | ||||||
Status: | REOPENED --- | ||||||||
Severity: | Normal | CC: | commit-queue, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jfernandez, kondapallykalyan, louis.acresti, macpherson, menard, pdr, rego, simon.fraser, svillar, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.chromium.org/p/chromium/issues/detail?id=1024927 | ||||||||
Bug Depends on: | 210617 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Oriol Brufau
2019-11-25 11:13:04 PST
Created attachment 387660 [details]
Patch
Comment on attachment 387660 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387660&action=review r=me. Thanks for taking care of this. > Source/WebCore/rendering/RenderGrid.cpp:872 > + // Usually we have `explicitEnd <= numPositions - 1`, but the latter may be > + // smaller when the maximum number of tracks is reached. Super nit: Not need to wrap this comment line, it's not that long for WebKit standards. Created attachment 387768 [details]
Patch
Comment on attachment 387768 [details]
Patch
Fixed nit
The commit-queue encountered the following flaky tests while processing attachment 387768 [details]: inspector/worker/debugger-pause.html bug 206285 (authors: drousso@apple.com and joepeck@webkit.org) The commit-queue is continuing to process your patch. Comment on attachment 387768 [details] Patch Clearing flags on attachment: 387768 Committed r254561: <https://trac.webkit.org/changeset/254561> All reviewed patches have been landed. Closing bug. Chromium has reverted this change since it was breaking some live sites, mainly devtool-like website building apps like webflow.com and educational tools like gridcritters.com. More info: - https://bugs.chromium.org/p/chromium/issues/detail?id=1069866 - https://github.com/w3c/csswg-drafts/issues/4475#issuecomment-613032475 Sounds like the Chromium team are postponing the feature until there's an API for getting measurements of implicit tracks. Disclaimer: I work at Webflow on the team responsible for the CSS Grid feature that broke due to the change in `getComputedStyle`'s API. (In reply to Lou Acresti from comment #9) > Chromium has reverted this change since it was breaking some live sites, > mainly devtool-like website building apps like webflow.com and educational > tools like gridcritters.com. > > More info: > > - https://bugs.chromium.org/p/chromium/issues/detail?id=1069866 > - https://github.com/w3c/csswg-drafts/issues/4475#issuecomment-613032475 > > Sounds like the Chromium team are postponing the feature until there's an > API for getting measurements of implicit tracks. > > Disclaimer: I work at Webflow on the team responsible for the CSS Grid > feature that broke due to the change in `getComputedStyle`'s API. Yes we should revert here too, please Oriol take care of reverting the patch. It seems "we were lucky" and this didn't make it to Safari 13.1, so just reverting in trunk would be fine I guess. Adding Simon on CC just in case we need to do anything else. |