Summary: | Queuing a task in EventLoop is not working with UserMediaRequest allow completion handler | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||
Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cdumez, commit-queue, eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, rniwa, sergio, tommyw, webkit-bug-importer, youennf | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
youenn fablet
2019-11-24 23:18:01 PST
Created attachment 384277 [details]
Patch
Comment on attachment 384277 [details]
Patch
Interesting. I wonder if this is a common pattern. If so, we can add a variant of queueTaskKeepingObjectAlive which takes a completion handler & automatically calls it in the case the task is dropped because the event loop knows when an active DOM object is stopped.
(In reply to Ryosuke Niwa from comment #3) > Comment on attachment 384277 [details] > Patch > > Interesting. I wonder if this is a common pattern. If so, we can add a > variant of queueTaskKeepingObjectAlive which takes a completion handler & > automatically calls it in the case the task is dropped because the event > loop knows when an active DOM object is stopped. I did a grep of queueTaskKeepingObjectAlive and completionHandler and only found this place, hence the change of bug title and current patch. If we run in the same issue in the future, we might indeed try to find a better solution. Comment on attachment 384277 [details] Patch Clearing flags on attachment: 384277 Committed r252878: <https://trac.webkit.org/changeset/252878> All reviewed patches have been landed. Closing bug. |