Summary: | [GTK][WPE] RemoteInspector: use sockets instead of DBus | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | annulen, Basuke.Suzuki, benjamin, bugs-noreply, cdumez, clopez, cmarcelo, dbates, ews-watchlist, gyuyoung.kim, hi, Hironori.Fujii, joepeck, keith_miller, mark.lam, msaboff, ross.kirsling, ryuan.choi, saam, sergio, tzagallo, zan | ||||
Priority: | P2 | Keywords: | Gtk | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Carlos Garcia Campos
2019-11-22 03:34:51 PST
Created attachment 384141 [details]
Patch
Will it be protocol-compatible with generic implementation in inspector/remote/socket? Comment on attachment 384141 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384141&action=review > Source/WTF/wtf/glib/SocketConnection.cpp:125 > + memmove(m_readBuffer.data(), m_readBuffer.data() + messageSize, m_readBuffer.size() - messageSize); This could be std::memmove(). > Source/WTF/wtf/glib/SocketConnection.cpp:175 > + memmove(m_writeBuffer.data(), m_writeBuffer.data() + bytesWritten, m_writeBuffer.size() - bytesWritten); And this too. (In reply to Konstantin Tokarev from comment #2) > Will it be protocol-compatible with generic implementation in > inspector/remote/socket? No, the message format is different. Committed r252770: <https://trac.webkit.org/changeset/252770> (In reply to Carlos Garcia Campos from comment #4) > (In reply to Konstantin Tokarev from comment #2) > > Will it be protocol-compatible with generic implementation in > > inspector/remote/socket? > > No, the message format is different. How can we address this? It's really wasteful and unfortunate to have GTK/WPE move from DBus to sockets only to use a different implementation from the one that's meant for generic use. Basuke has had the socket-based inspector working downstream on GTK port for a long time, it just was higher-priority for us to get the WinCairo / PlayStation parts upstreamed first. Hopefully we can work together to realize a common solution. We want to keep using GVariant for the message parameters, it's a lot more convenient when sending complex data, and probably more efficient too. |