Bug 204497

Summary: Crash in WebCore::ServiceWorkerRegistrationKey::hash() const
Product: WebKit Reporter: youenn fablet <youennf>
Component: Service WorkersAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description youenn fablet 2019-11-22 02:01:19 PST
Nullpointer crash in WebCore: WebCore::ServiceWorkerRegistrationKey::hash() const
Comment 1 youenn fablet 2019-11-22 02:01:29 PST
<rdar://problem/57348603>
Comment 2 youenn fablet 2019-11-22 02:17:26 PST
Created attachment 384135 [details]
Patch
Comment 3 Chris Dumez 2019-11-22 08:33:40 PST
Comment on attachment 384135 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384135&action=review

> Source/WebCore/workers/service/ServiceWorkerRegistrationKey.cpp:52
> +    hashes[1] = m_scope.isNull() ? 0 : StringHash::hash(m_scope);

This part of the change looks wrong me.
Comment 4 youenn fablet 2019-11-22 11:24:05 PST
Created attachment 384178 [details]
Patch
Comment 5 WebKit Commit Bot 2019-11-25 01:15:22 PST
Comment on attachment 384178 [details]
Patch

Clearing flags on attachment: 384178

Committed r252849: <https://trac.webkit.org/changeset/252849>
Comment 6 WebKit Commit Bot 2019-11-25 01:15:24 PST
All reviewed patches have been landed.  Closing bug.