Bug 20449

Summary: Build fails if LOW_BANDWIDTH_DISPLAY is defined
Product: WebKit Reporter: Chris Teague <chris.teague>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Attachments:
Description Flags
Proposed fix for compile issue mrowe: review+

Description Chris Teague 2008-08-19 15:06:30 PDT
The arm-linux variant does not compile successfully. This bug has been in the nightly since at least r35788, and as recently as r35814.  To reproduce, build with this command line:
./autogen.sh --host=arm-linux --prefix=/usr
make

The errors produced are:
WebCore/loader/FrameLoader.cpp: In member function `void
WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady()':
WebCore/loader/FrameLoader.cpp:5032: error: 'class
WebCore::ScriptController' has no member named clear'
WebCore/loader/FrameLoader.cpp:5037: error: `instance' is not a member
of `WebCore::DOMImplementation'
make[1]: *** [WebCore/loader/libWebCore_la-FrameLoader.lo] Error 1
Comment 1 Mark Rowe (bdash) 2008-08-19 16:51:42 PDT
*** Bug 20450 has been marked as a duplicate of this bug. ***
Comment 2 Mark Rowe (bdash) 2008-08-19 16:55:38 PDT
The code in question is surrounded by an #if USE(LOW_BANDWIDTH_DISPLAY), which is off on every platform.  This suggest that you've modified your tree to turn this on, and that the steps you mention to reproduce will not work without a similar modification.
Comment 3 Chris Teague 2008-08-19 16:59:48 PDT
(In reply to comment #2)
> The code in question is surrounded by an #if USE(LOW_BANDWIDTH_DISPLAY), which
> is off on every platform.  This suggest that you've modified your tree to turn
> this on, and that the steps you mention to reproduce will not work without a
> similar modification.
> 

Yes, my normal build does in fact turn on the LOW_BANDWIDTH_DISPLAY feature.  However, I did try to build without that turned on, and received the same error.  It sounds like I must have not turned off the low bandwidth when I thought I had.  I will re-try with a clean copy of the latest nightly, and with the LOW_BANDWIDTH_DISPLAY turned off.
Comment 4 Chris Teague 2008-08-19 23:30:23 PDT
Created attachment 22887 [details]
Proposed fix for compile issue

I think this updates the LOW_BANDWIDTH_DISPLAY code to use the new api's.  This is my first Webkit patch, please let me know if I've done something wrong.
Comment 5 Mark Rowe (bdash) 2008-08-20 15:12:22 PDT
Comment on attachment 22887 [details]
Proposed fix for compile issue

r=me. A minor issue in your patch is that you have a tab in your ChangeLog entry.  I'll fix that as I land your patch.
Comment 6 Mark Rowe (bdash) 2008-08-20 15:16:20 PDT
Landed in r35863.