Summary: | Build fails if LOW_BANDWIDTH_DISPLAY is defined | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Teague <chris.teague> | ||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | ||||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Chris Teague
2008-08-19 15:06:30 PDT
*** Bug 20450 has been marked as a duplicate of this bug. *** The code in question is surrounded by an #if USE(LOW_BANDWIDTH_DISPLAY), which is off on every platform. This suggest that you've modified your tree to turn this on, and that the steps you mention to reproduce will not work without a similar modification. (In reply to comment #2) > The code in question is surrounded by an #if USE(LOW_BANDWIDTH_DISPLAY), which > is off on every platform. This suggest that you've modified your tree to turn > this on, and that the steps you mention to reproduce will not work without a > similar modification. > Yes, my normal build does in fact turn on the LOW_BANDWIDTH_DISPLAY feature. However, I did try to build without that turned on, and received the same error. It sounds like I must have not turned off the low bandwidth when I thought I had. I will re-try with a clean copy of the latest nightly, and with the LOW_BANDWIDTH_DISPLAY turned off. Created attachment 22887 [details]
Proposed fix for compile issue
I think this updates the LOW_BANDWIDTH_DISPLAY code to use the new api's. This is my first Webkit patch, please let me know if I've done something wrong.
Comment on attachment 22887 [details]
Proposed fix for compile issue
r=me. A minor issue in your patch is that you have a tab in your ChangeLog entry. I'll fix that as I land your patch.
|