Bug 204483

Summary: [Win] Try splitting out MiniBrowserLegacy from MiniBrowser
Product: WebKit Reporter: Ross Kirsling <ross.kirsling>
Component: Tools / TestsAssignee: Ross Kirsling <ross.kirsling>
Status: RESOLVED WONTFIX    
Severity: Normal CC: annulen, bfulgham, don.olmstead, ews-watchlist, gyuyoung.kim, Hironori.Fujii, pvollan, ryuan.choi, sergio
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch Hironori.Fujii: review-, Hironori.Fujii: commit-queue-

Ross Kirsling
Reported 2019-11-21 17:43:49 PST
An idea that Don suggested: We might like to get rid of WKL for WinCairo, but it's important that we don't break AppleWin. Now, we could add #ifs to allow for a complete --no-legacy build, but presumably our bots would still need to build both, meaning that the flag could get stale. What would work though, is to have separate WK1 and WK2 MiniBrowser executables, along the same lines as DRT / WKTR. --- My understanding is that Fujii-san is not on board with this idea, but I hope that a concrete patch will enable us to have a rational discussion about it.
Attachments
Patch (299.69 KB, patch)
2019-11-21 17:55 PST, Ross Kirsling 		Hironori.Fujii: review-
Hironori.Fujii: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ross Kirsling
Comment 1 2019-11-21 17:55:13 PST
Created attachment 384112 [details] Patch
Ross Kirsling
Comment 2 2019-11-21 18:02:11 PST
Comment on attachment 384112 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384112&action=review > Tools/ChangeLog:10 > + Procedure: I forgot step 0: Use the Windows message loop directly on WK2 (and not IWebKitMessageLoopPtr). That part needs to be done with or without this patch.
Fujii Hironori
Comment 3 2019-11-22 02:53:39 PST
Comment on attachment 384112 [details] Patch As you know I strongly objecting this idea. Don't copy the code at the moment. It increase my maintained cost of webkit1 and webkit2.
Ross Kirsling
Comment 4 2019-11-25 18:12:36 PST
Closing in favor of bug 204592.
Note You need to log in before you can comment on or make changes to this bug.