Bug 204448

Summary: Optimize dynamic media queries
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: emilio, eric.carlson, esprehn+autocc, ews-watchlist, ggaren, glenn, gyuyoung.kim, jer.noble, macpherson, menard, philipj, sergio
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 204449, 205263, 205264, 205391, 205392, 205406    
Bug Blocks:    
Attachments:
Description Flags
wip
none
wip none

Antti Koivisto
Reported 2019-11-21 01:38:58 PST
All media queries currently force full style resolver rebuild when a query evaluation changes (for example viewport queries on window resizing or device rotation). This is very inefficient. We should treat media queries more like selectors, avoid rebuilds, and only perform the needed style recalcs.
Attachments
wip (31.10 KB, patch)
2019-12-13 05:42 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
wip (31.82 KB, patch)
2019-12-13 09:42 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2019-11-21 07:35:05 PST
<rdar://problem/40768292>
Antti Koivisto
Comment 2 2019-12-13 05:42:33 PST
Created attachment 385595 [details] wip
Antti Koivisto
Comment 3 2019-12-13 09:42:13 PST
Created attachment 385611 [details] wip
Antti Koivisto
Comment 4 2019-12-20 08:52:08 PST
This is done.
Note You need to log in before you can comment on or make changes to this bug.