Bug 204445

Summary: add ASSERT_NOT_REACHED_WITH_MESSAGE and RELEASE_ASSERT_NOT_REACHED_WITH_MESSAGE
Product: WebKit Reporter: Tuomas Karkkainen <tuomas.webkit>
Component: Web Template FrameworkAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, koivisto, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch
none
proposed patch
koivisto: review+
proposed patch none

Tuomas Karkkainen
Reported 2019-11-21 00:22:34 PST
Add ASSERT_NOT_REACHED_WITH_MESSAGE and RELEASE_ASSERT_NOT_REACHED_WITH_MESSAGE to allow adding a message to code paths not expected to be reached, or to avoid the need to use a dummy assertion of 0 or false for the same effect.
Attachments
proposed patch (2.73 KB, patch)
2019-11-21 00:27 PST, Tuomas Karkkainen 		no flags
DetailsFormatted DiffDiff
proposed patch (2.42 KB, patch)
2019-11-21 03:56 PST, Tuomas Karkkainen 		koivisto: review+
DetailsFormatted DiffDiff
proposed patch (1.75 KB, patch)
2019-11-21 04:15 PST, Tuomas Karkkainen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Tuomas Karkkainen
Comment 1 2019-11-21 00:27:50 PST
Created attachment 384033 [details] proposed patch
Tuomas Karkkainen
Comment 2 2019-11-21 03:56:09 PST
Created attachment 384043 [details] proposed patch address issues brought up in review.
Antti Koivisto
Comment 3 2019-11-21 04:01:31 PST
Comment on attachment 384043 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=384043&action=review > Source/WTF/wtf/Assertions.h:315 > +#define ASSERT_NOT_REACHED_WITH_MESSAGE(...) ((void)0) This too should be inside #ifdef __cplusplus for consistency.
Tuomas Karkkainen
Comment 4 2019-11-21 04:15:51 PST
Created attachment 384044 [details] proposed patch cleanup
WebKit Commit Bot
Comment 5 2019-11-21 04:59:18 PST
Comment on attachment 384044 [details] proposed patch Clearing flags on attachment: 384044 Committed r252731: <https://trac.webkit.org/changeset/252731>
WebKit Commit Bot
Comment 6 2019-11-21 04:59:20 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-11-21 05:00:26 PST
<rdar://problem/57391975>
Note You need to log in before you can comment on or make changes to this bug.