Bug 204425

Summary:

[WinCairo] webkitpy style/filter_unittest fails on Windows Python

Product:

WebKit

Reporter:

Stephan Szabo <stephan.szabo>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

bfulgham, cjerdonek, don.olmstead, ews-watchlist, glenn, Hironori.Fujii, jbedard, ross.kirsling

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Stephan Szabo 2019-11-20 15:13:35 PST

test_path_with_different_case fails with Windows (non-cygwin/msys) python.
It appears this is because the file paths being checked are normalized and end up with backslash delimiters, while the path specific rule is using a hardcoded forward slash.

When setting up the actual configuration for style checking, os.path.join appears to be used and gets the correctly delimited paths, so I'm proposing that we do similar in this test.

Comment 1 Stephan Szabo 2019-11-20 15:15:30 PST

Created attachment 383989 [details]
Patch

Comment 2 Jonathan Bedard 2019-11-20 15:48:02 PST

You wrote this patch with a 3 month old checkout (look at the commit below yours in the changelog). Can you please rebase? I know there have been some changes in this area with Python 3 work. I suspect the bug is still present, but the change might look different.

Comment 3 Stephan Szabo 2019-11-20 15:57:14 PST

Created attachment 383999 [details]
Patch

Updated to more recent pull.

Comment 4 Stephan Szabo 2019-11-20 15:59:29 PST

Comment on attachment 383999 [details]
Patch

Obsoleting until I check it again.

Comment 5 Stephan Szabo 2019-11-20 16:17:34 PST

Thanks for mentioning it. It looks like the changes for python 3 must have fixed the issue, sorry for the noise.

Comment 6 Stephan Szabo 2019-11-20 16:23:01 PST

Ah, no, I see, we've got a downstream fix for another version of badness with the style code on Windows that broke the test. Will try to get the whole thing up instead once I figure out what the original fix was for. :(