Summary: | [EWS] iOS layout-tests fails with 30+ failures on re-run and on clean-tree | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||
Component: | New Bugs | Assignee: | Jonathan Bedard <jbedard> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, commit-queue, jbedard, simon.fraser, webkit-bot-watchers-bugzilla, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | Other | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=203792 https://bugs.webkit.org/show_bug.cgi?id=204415 https://bugs.webkit.org/show_bug.cgi?id=204416 https://bugs.webkit.org/show_bug.cgi?id=204417 |
||||||
Attachments: |
|
Description
Aakash Jain
2019-11-20 05:14:37 PST
This issue stalls iOS WK2 queue whenever there is any failure on trunk. I don't understand how clean-tree results are somehow more flakey than the test runs with the patch. This seems like another fallout from Catalina update on iOS bots. We updated the bots around Oct 30, and we started seeing 30+ layout-test failure in https://bugs.webkit.org/show_bug.cgi?id=203792 That issue was fixed on Nov 10. I believe this issue has been happening since then. I bet that running kill-old-processes between runs would help. As Alexey pointed out, this is probably a bug of some sort, so I just landed <https://trac.webkit.org/r252691> to help us figure out what the problem is. Created attachment 383974 [details]
Patch
Comment on attachment 383974 [details] Patch Now that we have some logging from <https://trac.webkit.org/r252691>, it seems to be simulator and https. I'll work on fixes for those problems independently, but as I mention offline to Aakash: "I think the kill-old-processes stuff needs to land. If nothing else, it's possible that a patch which fails to clean up resources appropriately could cause failures in the clean run and cause us to mark the patch as 'good' even though it is demonstrably not" Committed r252700: <https://trac.webkit.org/changeset/252700> Comment on attachment 383974 [details]
Patch
Landed manually, removing flags.
|