Bug 204397 – MicrotaskQueue should be accessed via EventLoop

• Component: DOM
• Status: RESOLVED FIXED

[Ryosuke Niwa]

In order to integrate MicrotaskQueue, refactor the existing code to always access it via EventLoop.

[Ryosuke Niwa]

Created attachment 383948 [details]
Refactoring

[Radar WebKit Bug Importer]

<rdar://problem/57351294>

[Ryosuke Niwa]

Once this patch is landed, there are a few bugs to fix:
 - MutationObserver's compound microtask queue must be per similar origin windows; i.e. per event loop. This should let us remove the hack we added in https://trac.webkit.org/r247222.
 - Custom Element's backup queue must be per micro per similar origin windows; i.e. per event loop. This will be observable via editing commands issued across sites.
 - EventLoopTaskQueue::queueMicrotaskCallback should automatically suspend or stop microtasks if the associated script execution context is suspend or stopped like regular EventLoopTasks. This will let us remove ActiveDOMCallbackMicrotask.

[Antti Koivisto]

Comment on attachment 383948 [details]
Refactoring

View in context: https://bugs.webkit.org/attachment.cgi?id=383948&action=review

> Source/WebCore/dom/MutationObserver.cpp:163
> +// This state must be per event loop.
> +static bool mutationObserverCompoundMicrotaskQueuedFlag = false;

I suppose this is a FIXME.

> Source/WebCore/dom/WindowEventLoop.cpp:78
> +    // MicrotaskQueue must be one per event loop.

FIXME

[Ryosuke Niwa]

Committed r252723: <https://trac.webkit.org/changeset/252723>

[Fujii Hironori]

Filed: Bug 204437 – [MSVC] error C2039: 'weakPtrFactory': is not a member of 'WebCore::DocumentStorageAccess::requestStorageAccess::<lambda_3f2cfd7704f93d8fe19d5b5f064f8add>'