Bug 204377

Summary: Protect MessageReceivers when possible while they are processing incoming IPC messages
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, benjamin, commit-queue, ddkilzer, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, jiewen_tan, philipj, rniwa, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2019-11-19 14:31:39 PST
Protect WebProcessProxy / WebPageProxy while they are processing incoming IPC messages for extra safety. It is a common mistake to call client delegates and failing to protect |this| while doing so. Client code can destroy the WebProcessProxy / WebPageProxy pretty easily, leading to crashes.
Attachments
Patch (4.71 KB, patch)
2019-11-19 14:33 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (38.35 KB, patch)
2019-11-19 15:09 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2019-11-19 14:33:53 PST
Created attachment 383905 [details] Patch
Chris Dumez
Comment 2 2019-11-19 14:44:48 PST
Comment on attachment 383905 [details] Patch Trying out an alternative proposal from Brady.
Chris Dumez
Comment 3 2019-11-19 15:09:00 PST
Created attachment 383911 [details] Patch
Chris Dumez
Comment 4 2019-11-19 16:32:26 PST
Comment on attachment 383911 [details] Patch Clearing flags on attachment: 383911 Committed r252655: <https://trac.webkit.org/changeset/252655>
Chris Dumez
Comment 5 2019-11-19 16:32:28 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-11-19 16:33:21 PST
<rdar://problem/57341959>
Note You need to log in before you can comment on or make changes to this bug.