Bug 204283

Summary:

Add initial support for WebRTC HEVC

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

WebRTC

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

agouaillard, annulen, dibotero, eric.carlson, ews-watchlist, glenn, gyuyoung.kim, hta, jer.noble, philipj, ryuan.choi, sergio, sun.shin, tommyw, tsavell, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=210173
https://bugs.webkit.org/show_bug.cgi?id=258794

Attachments:

Description	Flags
Patch	none
Patch	none
Rebased on top of M82	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch for landing	none

youenn fablet

Reported 2019-11-16 23:22:55 PST

Add initial support for WebRTC HEVC

Attachments
Patch (263.26 KB, patch) 2019-11-16 23:25 PST, youenn fablet	no flags	Details Formatted Diff Diff
Patch (530.46 KB, patch) 2019-11-17 02:53 PST, youenn fablet	no flags	Details Formatted Diff Diff
Rebased on top of M82 (250.77 KB, patch) 2020-03-30 04:33 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (250.05 KB, patch) 2020-04-01 08:09 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (240.48 KB, patch) 2020-04-01 09:26 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (250.01 KB, patch) 2020-04-01 09:57 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (250.50 KB, patch) 2020-04-02 00:21 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (250.36 KB, patch) 2020-04-02 03:12 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (250.39 KB, patch) 2020-04-02 05:05 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch for landing (246.74 KB, patch) 2020-04-03 02:53 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Show Obsolete (9) View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2019-11-16 23:23:09 PST

See https://github.com/open-webrtc-toolkit

youenn fablet

Comment 2 2019-11-16 23:25:37 PST

Created attachment 383716 [details] Patch

youenn fablet

Comment 3 2019-11-17 02:53:18 PST

Created attachment 383719 [details] Patch

youenn fablet

Comment 4 2020-03-30 04:33:13 PDT

Created attachment 394903 [details] Rebased on top of M82

youenn fablet

Comment 5 2020-04-01 08:09:55 PDT

Created attachment 395167 [details] Patch

youenn fablet

Comment 6 2020-04-01 09:26:01 PDT

Created attachment 395176 [details] Patch

youenn fablet

Comment 7 2020-04-01 09:57:44 PDT

Created attachment 395180 [details] Patch

youenn fablet

Comment 8 2020-04-02 00:21:48 PDT

Created attachment 395246 [details] Patch

youenn fablet

Comment 9 2020-04-02 03:12:35 PDT

Created attachment 395257 [details] Patch

youenn fablet

Comment 10 2020-04-02 05:05:55 PDT

Created attachment 395261 [details] Patch

Eric Carlson

Comment 11 2020-04-02 10:12:57 PDT

Comment on attachment 395261 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395261&action=review > LayoutTests/webrtc/h265.html:58 > + setTimeout(() => reject("Test timed out"), 2000); Will 2 seconds long be long enough on a heavily loaded machine? > LayoutTests/webrtc/h265.html:74 > + setTimeout(() => reject("Test timed out"), 2000); Ditto.

youenn fablet

Comment 12 2020-04-03 02:53:24 PDT

Created attachment 395361 [details] Patch for landing

EWS

Comment 13 2020-04-03 03:46:08 PDT

Committed r259452: <https://trac.webkit.org/changeset/259452> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395361 [details].

Radar WebKit Bug Importer

Comment 14 2020-04-03 03:47:15 PDT

<rdar://problem/61253198>

Truitt Savell

Comment 15 2020-04-07 12:02:47 PDT

The new test webrtc/h265.html added in https://trac.webkit.org/changeset/259452/webkit Is a constant timeout on iOS history: https://results.webkit.org/?suite=layout-tests&test=webrtc%2Fh265.html Can this get resolved soon?

Ryan Haddad

Comment 16 2020-04-07 21:00:22 PDT

(In reply to Truitt Savell from comment #15) > The new test webrtc/h265.html > > added in https://trac.webkit.org/changeset/259452/webkit > > Is a constant timeout on iOS Filed https://bugs.webkit.org/show_bug.cgi?id=210173 to track.

[MSFT] Diego Perez Botero

Comment 17 2022-04-13 14:05:47 PDT

I still see "WebRTC H265 Codec" as an experimental feature defaulting to DISABLED on iOS. Are there plans to enable H265 for WebRTC on iOS in the near future?

Byungseon(Sun) Shin

Comment 18 2023-07-03 17:28:35 PDT

Adding related bugs: - Enabling HEVC by default: https://bugs.webkit.org/show_bug.cgi?id=242921 - Implementing RFC 7798 Packetization: https://bugs.webkit.org/show_bug.cgi?id=258794 @youenn could you please review the bugs?

Note You need to log in before you can comment on or make changes to this bug.