Bug 204210

Summary: Add SPI to clear web process cache
Product: WebKit Reporter: Ben Nham <nham>
Component: WebKit2Assignee: Ben Nham <nham>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, cdumez, commit-queue, koivisto, nham, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Ben Nham
Reported 2019-11-14 16:38:33 PST
We should add an SPI to kill cached web processes. The intended use case is to add a lukewarm mode to Mac PLT5 in which web pages load in a new WebProcess but load resources from the disk cache. Currently the warm run of PLT5 is small enough to fit inside the Mac's process pool size, so we only end up exercising the memory cache in the cached WebProcess when loading resources.
Attachments
Patch (2.94 KB, patch)
2019-11-14 16:50 PST, Ben Nham 		no flags
DetailsFormatted DiffDiff
Patch (2.33 KB, patch)
2019-11-15 11:17 PST, Ben Nham 		no flags
DetailsFormatted DiffDiff
Patch (2.45 KB, patch)
2019-11-15 12:59 PST, Ben Nham 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ben Nham
Comment 1 2019-11-14 16:50:56 PST
Created attachment 383584 [details] Patch
Chris Dumez
Comment 2 2019-11-15 08:07:40 PST
Comment on attachment 383584 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383584&action=review > Source/WebKit/UIProcess/API/Cocoa/WKProcessPool.mm:527 > + bool shouldTerminateCached = process->isInProcessCache() && (type & _WKWebProcessTerminationTypeCached); Calling WebProcessCache::clear() would do the right thing for clearing the process cache. Also, is there really value to clearing the prewarmed process?
Chris Dumez
Comment 3 2019-11-15 08:11:03 PST
Comment on attachment 383584 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383584&action=review > Source/WebKit/ChangeLog:3 > + Add SPI to clear web process cache The patch does more that that.
Ben Nham
Comment 4 2019-11-15 11:17:18 PST
Created attachment 383630 [details] Patch
Ben Nham
Comment 5 2019-11-15 11:19:01 PST
Comment on attachment 383630 [details] Patch remove option to kill prewarmed process
Chris Dumez
Comment 6 2019-11-15 11:43:20 PST
Comment on attachment 383630 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383630&action=review > Source/WebKit/UIProcess/API/Cocoa/WKProcessPool.mm:472 > +- (void)_terminateCachedWebProcesses I would call this _clearWebProcessCache
Ben Nham
Comment 7 2019-11-15 12:59:32 PST
Created attachment 383636 [details] Patch
Ben Nham
Comment 8 2019-11-15 12:59:59 PST
Comment on attachment 383636 [details] Patch change method name
WebKit Commit Bot
Comment 9 2019-11-15 13:51:59 PST
Comment on attachment 383636 [details] Patch Clearing flags on attachment: 383636 Committed r252500: <https://trac.webkit.org/changeset/252500>
WebKit Commit Bot
Comment 10 2019-11-15 13:52:01 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 11 2019-11-15 13:52:17 PST
<rdar://problem/57239080>
Note You need to log in before you can comment on or make changes to this bug.