Bug 204202

Summary: [iOS] Audio capture fails when a track is unmuted
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: WebRTCAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
jer.noble: review+
Patch
commit-queue: commit-queue-
Oops none

Description Eric Carlson 2019-11-14 12:59:00 PST 
Audio capture fails when a track is unmuted
Comment 1 Eric Carlson 2019-11-14 12:59:26 PST 
<rdar://problem/57005820>
Comment 2 Eric Carlson 2019-11-14 13:08:58 PST 
Created attachment 383571 [details]
Patch
Comment 3 Eric Carlson 2019-11-14 15:06:36 PST 
Created attachment 383575 [details]
Patch
Comment 4 youenn fablet 2019-11-14 15:52:17 PST 
Comment on attachment 383575 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383575&action=review

> Source/WebCore/ChangeLog:9
> +        Tested manually.

We now have assertions that would catch regressions in layout tests.
Comment 5 WebKit Commit Bot 2019-11-14 16:34:09 PST 
Comment on attachment 383575 [details]
Patch

Clearing flags on attachment: 383575

Committed r252470: <https://trac.webkit.org/changeset/252470>
Comment 6 WebKit Commit Bot 2019-11-14 16:34:10 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Eric Carlson 2019-11-15 14:49:14 PST 
Reopening to attach new patch.
Comment 8 Eric Carlson 2019-11-15 14:49:14 PST 
Created attachment 383654 [details]
Patch
Comment 9 Eric Carlson 2019-11-15 16:57:40 PST 
Created attachment 383667 [details]
Patch
Comment 10 WebKit Commit Bot 2019-11-15 19:27:01 PST 
Comment on attachment 383667 [details]
Patch

Rejecting attachment 383667 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 383667, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Tools/ChangeLog contains OOPS!.

Full output: https://webkit-queues.webkit.org/results/13259814
Comment 11 Eric Carlson 2019-11-15 19:40:49 PST 
Created attachment 383683 [details]
Oops
Comment 12 WebKit Commit Bot 2019-11-15 20:13:48 PST 
Comment on attachment 383683 [details]
Oops

Clearing flags on attachment: 383683

Committed r252521: <https://trac.webkit.org/changeset/252521>
Comment 13 WebKit Commit Bot 2019-11-15 20:13:50 PST 
All reviewed patches have been landed.  Closing bug.