Bug 20419

Summary: Remove op_jless
Product: WebKit Reporter: Cameron Zwarich (cpst) <zwarich>
Component: JavaScriptCoreAssignee: Cameron Zwarich (cpst) <zwarich>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed patch mjs: review+

Cameron Zwarich (cpst)
Reported 2008-08-17 13:01:41 PDT
After we added the loop opcodes, I wanted to remove op_jless, as we now have op_loop_if_less. It will only be used when less is inside of a logical operator, which doesn't really justify its continued existence. Removing it was originally a random slowdown on SunSpider, but now it's a 0.1% speedup.
Attachments
Proposed patch (3.89 KB, patch)
2008-08-17 13:03 PDT, Cameron Zwarich (cpst) 		mjs: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Cameron Zwarich (cpst)
Comment 1 2008-08-17 13:03:43 PDT
Created attachment 22845 [details] Proposed patch
Maciej Stachowiak
Comment 2 2008-08-17 14:07:19 PDT
Comment on attachment 22845 [details] Proposed patch r=me
Cameron Zwarich (cpst)
Comment 3 2008-08-17 14:09:31 PDT
*** Bug 19823 has been marked as a duplicate of this bug. ***
Cameron Zwarich (cpst)
Comment 4 2008-08-18 07:39:48 PDT
Landed in r35810.
Note You need to log in before you can comment on or make changes to this bug.