Bug 204142

Summary: check-webkit-style: fix false errors for obj-c method calls in range-based for statements using colon syntax
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, ews-watchlist, glenn, jbedard, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Megan Gardner
Reported 2019-11-12 21:59:44 PST
check-webkit-style: fix false errors for obj-c method calls in range-based for statements using colon syntax
Attachments
Patch (3.33 KB, patch)
2019-11-12 22:02 PST, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.41 KB, patch)
2019-11-13 14:11 PST, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Megan Gardner
Comment 1 2019-11-12 22:02:54 PST
Created attachment 383429 [details] Patch
Jonathan Bedard
Comment 2 2019-11-13 07:31:34 PST
Comment on attachment 383429 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383429&action=review Small nit about combining the regex check into the existing if statement, but other than that, it looks good! > Tools/Scripts/webkitpy/style/checkers/cpp.py:1988 > + if not search(r'\[[^\]]+:[^\]]*\]', condition): Seems like this should be on line 1987 with the rest of the if statement, so it looks like: if statement == 'for' and search(r'(?:[^ :]:[^:]|[^:]:[^ :])', condition) and not search(r'\[[^\]]+:[^\]]*\]', condition): error(...)
Megan Gardner
Comment 3 2019-11-13 14:11:02 PST
Created attachment 383494 [details] Patch for landing
WebKit Commit Bot
Comment 4 2019-11-13 14:57:02 PST
Comment on attachment 383494 [details] Patch for landing Clearing flags on attachment: 383494 Committed r252433: <https://trac.webkit.org/changeset/252433>
WebKit Commit Bot
Comment 5 2019-11-13 14:57:03 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-11-13 14:58:20 PST
<rdar://problem/57169493>
Note You need to log in before you can comment on or make changes to this bug.