Bug 204094

Summary: results.webkit.org: Support branches in run-javascriptcore-tests
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, commit-queue, dbates, ews-watchlist, ryanhaddad, webkit-bug-importer, zhifei_fang
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=204091
Attachments:
Description Flags
Patch
none
Patch for landing none

Jonathan Bedard
Reported 2019-11-11 16:55:35 PST
We should automatically determine the correct branch when uploading jsc results to the results database.
Attachments
Patch (2.40 KB, patch)
2020-02-03 16:23 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.71 KB, patch)
2020-02-04 13:27 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2020-02-03 16:23:15 PST
Created attachment 389596 [details] Patch
Aakash Jain
Comment 2 2020-02-04 12:35:14 PST
Comment on attachment 389596 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389596&action=review rs=me > Tools/Scripts/webkitdirs.pm:778 > +sub commitForDirectory($$) Maybe more appropriate place for this method would be in VCSUtils.pm next to svnRevisionForDirectory()
Jonathan Bedard
Comment 3 2020-02-04 13:27:36 PST
Created attachment 389696 [details] Patch for landing
WebKit Commit Bot
Comment 4 2020-02-04 14:17:47 PST
Comment on attachment 389696 [details] Patch for landing Clearing flags on attachment: 389696 Committed r255698: <https://trac.webkit.org/changeset/255698>
WebKit Commit Bot
Comment 5 2020-02-04 14:17:48 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2020-02-04 14:18:19 PST
<rdar://problem/59164749>
Note You need to log in before you can comment on or make changes to this bug.