Bug 204053

Summary: Stack allocate StyleResolver state
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, cdumez, commit-queue, darin, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch
none
patch none

Antti Koivisto
Reported 2019-11-09 15:10:48 PST
Get rid of the awkward State member.
Attachments
patch (38.18 KB, patch)
2019-11-09 15:27 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (39.76 KB, patch)
2019-11-09 15:37 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (40.08 KB, patch)
2019-11-09 16:26 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2019-11-09 15:27:02 PST
Created attachment 383228 [details] patch
Antti Koivisto
Comment 2 2019-11-09 15:37:08 PST
Created attachment 383231 [details] patch
Antti Koivisto
Comment 3 2019-11-09 16:26:23 PST
Created attachment 383232 [details] patch
alan
Comment 4 2019-11-09 19:47:26 PST
Comment on attachment 383232 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=383232&action=review > Source/WebCore/css/StyleResolver.cpp:465 > +std::unique_ptr<RenderStyle> StyleResolver::defaultStyleForElement(const Element* element) It's sad that we need to pass in a raw pointer just to figure out if it is an svg element.
Antti Koivisto
Comment 5 2019-11-09 23:16:14 PST
> It's sad that we need to pass in a raw pointer just to figure out if it is > an svg element. Bit silly yes. There is still lots of room for improvement here.
WebKit Commit Bot
Comment 6 2019-11-10 00:01:58 PST
Comment on attachment 383232 [details] patch Clearing flags on attachment: 383232 Committed r252313: <https://trac.webkit.org/changeset/252313>
WebKit Commit Bot
Comment 7 2019-11-10 00:02:00 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-11-11 17:00:33 PST
<rdar://problem/57099412>
Darin Adler
Comment 9 2019-11-12 09:04:18 PST
Comment on attachment 383232 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=383232&action=review > Source/WebCore/style/StyleBuilderState.h:48 > + RefPtr<const Element> element = nullptr; I think the "= nullptr" here is a no-op since any RefPtr starts out as nullptr.
Note You need to log in before you can comment on or make changes to this bug.