| Summary: | iOS: fast/events/scroll-subframe-in-rendering-update.html always fails | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||||||
| Component: | Tools / Tests | Assignee: | Ryosuke Niwa <rniwa> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | ap, commit-queue, rniwa, simon.fraser, webkit-bot-watchers-bugzilla, webkit-bug-importer, wenson_hsieh | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | Other | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=203839 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Aakash Jain
2019-11-09 03:55:52 PST
Diff:
--- /Volumes/Data/slave/ios-simulator-13-release-tests-wk2/build/layout-test-results/fast/events/scroll-subframe-in-rendering-update-expected.txt
+++ /Volumes/Data/slave/ios-simulator-13-release-tests-wk2/build/layout-test-results/fast/events/scroll-subframe-in-rendering-update-actual.txt
@@ -8,9 +8,10 @@
iframeAA.contentWindow.scrollTo(0, 1000); updateLayout(iframeAA)
PASS logs.length is 0
After requestAnimationFrame
-PASS logs.length is 3
-PASS logs.join(", ") is "A, AA, B"
+FAIL logs.length should be 3. Was 0.
+FAIL logs.join(", ") should be A, AA, B. Was .
PASS successfullyParsed is true
+Some tests failed.
TEST COMPLETE
This test was added 2 days back in http://trac.webkit.org/changeset/252205/webkit and has been failing on iOS since then. Ugh... frame flattening is in effect here. Created attachment 383229 [details]
Disable frame flattening
Ugh... I need to download & install a new iOS SDK to test this out. Doing that now. Committed r252311: <https://trac.webkit.org/changeset/252311> Ugh... I can't either SSH into my machine or download the iOS SDK. Landing the fix speculatively for now. If this doesn't work, we probably need to skip the test on iOS for now until I regain access to a machine with functional iOS SDK. (In reply to Ryosuke Niwa from comment #8) > Committed r252311: <https://trac.webkit.org/changeset/252311> Seems to be still failing. https://build.webkit.org/builders/Apple%20iOS%2013%20Simulator%20Release%20WK2%20%28Tests%29/builds/975 Oh, I think we probably also need <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->. Added the failing expectation in https://trac.webkit.org/r252312 for now. Created attachment 383237 [details]
Fix attempt no.2
It's really annoying that we need to enable random ass flags in the tests to make scrolling tests to work in iOS. We should probably flip the default so that async scrolling is enabled by default so that many of existing layout tests for scrolling behavior can be enabled on iOS, and create a separate set of tests for frame flattening. (In reply to Ryosuke Niwa from comment #13) > Created attachment 383237 [details] > Fix attempt no.2 Did you want to update the TestExpectations as well? I guess EWS results for this patch wouldn't have covered this test because we pass --skip-failing-tests to run-webkit-tests in EWS. (In reply to Aakash Jain from comment #15) > (In reply to Ryosuke Niwa from comment #13) > > Created attachment 383237 [details] > > Fix attempt no.2 > Did you want to update the TestExpectations as well? > > I guess EWS results for this patch wouldn't have covered this test because > we pass --skip-failing-tests to run-webkit-tests in EWS. WTF!? When did we start doing that? Created attachment 383251 [details]
Patch for landing
Comment on attachment 383251 [details]
Patch for landing
Wait for EWS.
(In reply to Ryosuke Niwa from comment #16) > (In reply to Aakash Jain from comment #15) > > (In reply to Ryosuke Niwa from comment #13) > > > Created attachment 383237 [details] > > > Fix attempt no.2 > > Did you want to update the TestExpectations as well? > > > > I guess EWS results for this patch wouldn't have covered this test because > > we pass --skip-failing-tests to run-webkit-tests in EWS. > > WTF!? When did we start doing that? Seems like we started it in https://trac.webkit.org/changeset/106518/webkit Comment on attachment 383251 [details] Patch for landing Clearing flags on attachment: 383251 Committed r252317: <https://trac.webkit.org/changeset/252317> All reviewed patches have been landed. Closing bug. |