Summary: | Make MediaStream/MediaStreamTrack page cache friendly | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||
Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | cdumez, commit-queue, eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, rniwa, sergio, tommyw, webkit-bug-importer, youennf | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
youenn fablet
2019-11-08 16:30:02 PST
Created attachment 383183 [details]
Patch
Created attachment 383192 [details]
Patch
Comment on attachment 383192 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383192&action=review > Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp:578 > + scriptExecutionContext()->postTask([this, pendingActivity = makePendingActivity(*this)](auto&) { We're not supposed to use postTask() anymore. Please use the HTML event loop by calling queueTaskToDispatchEvent(). Also, because the HTML event loop is page-cache compliant, you can call queueTaskToDispatchEvent() in suspend() and then you don't need a resume() method or the m_isSuspendedForBackForwardCache flag. Created attachment 383276 [details]
Patch
Created attachment 383278 [details]
Patch
Comment on attachment 383278 [details]
Patch
r=me if the bots are happy.
Comment on attachment 383278 [details] Patch Clearing flags on attachment: 383278 Committed r252337: <https://trac.webkit.org/changeset/252337> All reviewed patches have been landed. Closing bug. *** Bug 203094 has been marked as a duplicate of this bug. *** |