Bug 204021

Summary: Add punctuation rules for C++ lambdas
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: New BugsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: ross.kirsling, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Add punctuation rules for C++ lambdas zalan: review+, zalan: commit-queue-

Description Ryosuke Niwa 2019-11-08 13:56:02 PST
Add punctuation rules for C++ lambdas
Comment 1 Ryosuke Niwa 2019-11-08 13:58:57 PST
Created attachment 383160 [details]
Add punctuation rules for C++ lambdas
Comment 2 Ross Kirsling 2019-11-08 14:17:29 PST
Comment on attachment 383160 [details]
Add punctuation rules for C++ lambdas

View in context: https://bugs.webkit.org/attachment.cgi?id=383160&action=review

> Websites/webkit.org/code-style.md:900
> +[](#punctuation-omit-lambda-paren) Omit parantheses for a C++ lambda whenever possible

nit: parantheses -> parentheses
Comment 3 Ross Kirsling 2019-11-08 14:18:17 PST
(In reply to Ross Kirsling from comment #2)
> Comment on attachment 383160 [details]
> Add punctuation rules for C++ lambdas
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=383160&action=review
> 
> > Websites/webkit.org/code-style.md:900
> > +[](#punctuation-omit-lambda-paren) Omit parantheses for a C++ lambda whenever possible
> 
> nit: parantheses -> parentheses

(Also a missing period.)
Comment 4 Ryosuke Niwa 2019-11-12 23:05:01 PST
(In reply to Ross Kirsling from comment #3)
> (In reply to Ross Kirsling from comment #2)
> > Comment on attachment 383160 [details]
> > Add punctuation rules for C++ lambdas
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=383160&action=review
> > 
> > > Websites/webkit.org/code-style.md:900
> > > +[](#punctuation-omit-lambda-paren) Omit parantheses for a C++ lambda whenever possible
> > 
> > nit: parantheses -> parentheses
> 
> (Also a missing period.)

Fixed.
Comment 5 Ryosuke Niwa 2019-11-13 01:25:19 PST
Committed r252395: <https://trac.webkit.org/changeset/252395>
Comment 6 Radar WebKit Bug Importer 2019-11-13 01:26:18 PST
<rdar://problem/57146959>