Bug 204021

Summary: Add punctuation rules for C++ lambdas
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: New BugsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: ross.kirsling, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Add punctuation rules for C++ lambdas zalan: review+, zalan: commit-queue-

Ryosuke Niwa
Reported 2019-11-08 13:56:02 PST
Add punctuation rules for C++ lambdas
Attachments
Add punctuation rules for C++ lambdas (1.88 KB, patch)
2019-11-08 13:58 PST, Ryosuke Niwa 		zalan: review+
zalan: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2019-11-08 13:58:57 PST
Created attachment 383160 [details] Add punctuation rules for C++ lambdas
Ross Kirsling
Comment 2 2019-11-08 14:17:29 PST
Comment on attachment 383160 [details] Add punctuation rules for C++ lambdas View in context: https://bugs.webkit.org/attachment.cgi?id=383160&action=review > Websites/webkit.org/code-style.md:900 > +[](#punctuation-omit-lambda-paren) Omit parantheses for a C++ lambda whenever possible nit: parantheses -> parentheses
Ross Kirsling
Comment 3 2019-11-08 14:18:17 PST
(In reply to Ross Kirsling from comment #2) > Comment on attachment 383160 [details] > Add punctuation rules for C++ lambdas > > View in context: > https://bugs.webkit.org/attachment.cgi?id=383160&action=review > > > Websites/webkit.org/code-style.md:900 > > +[](#punctuation-omit-lambda-paren) Omit parantheses for a C++ lambda whenever possible > > nit: parantheses -> parentheses (Also a missing period.)
Ryosuke Niwa
Comment 4 2019-11-12 23:05:01 PST
(In reply to Ross Kirsling from comment #3) > (In reply to Ross Kirsling from comment #2) > > Comment on attachment 383160 [details] > > Add punctuation rules for C++ lambdas > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=383160&action=review > > > > > Websites/webkit.org/code-style.md:900 > > > +[](#punctuation-omit-lambda-paren) Omit parantheses for a C++ lambda whenever possible > > > > nit: parantheses -> parentheses > > (Also a missing period.) Fixed.
Ryosuke Niwa
Comment 5 2019-11-13 01:25:19 PST
Committed r252395: <https://trac.webkit.org/changeset/252395>
Radar WebKit Bug Importer
Comment 6 2019-11-13 01:26:18 PST
<rdar://problem/57146959>
Note You need to log in before you can comment on or make changes to this bug.