| Summary: | Many legacy animation tests are timing out with VS2019 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Per Arne Vollan <pvollan> | ||||||
| Component: | Tools / Tests | Assignee: | Per Arne Vollan <pvollan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aakash_jain, ap, bfulgham, commit-queue, dino, dstockwell, ews-watchlist, Hironori.Fujii, simon.fraser, tsavell, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 197288 | ||||||||
| Attachments: |
|
||||||||
|
Description
Per Arne Vollan
2019-11-08 08:07:54 PST
Created attachment 383222 [details]
Patch
Comment on attachment 383222 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383222&action=review > Source/WebCore/page/animation/KeyframeAnimation.cpp:522 > +#endif Do we need this for ImplicitAnimation::timeToNextService, too? Comment on attachment 383222 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383222&action=review >> Source/WebCore/page/animation/KeyframeAnimation.cpp:522 >> +#endif > > Do we need this for ImplicitAnimation::timeToNextService, too? That method has the same logic for early return. (In reply to Brent Fulgham from comment #3) > Comment on attachment 383222 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=383222&action=review > > >> Source/WebCore/page/animation/KeyframeAnimation.cpp:522 > >> +#endif > > > > Do we need this for ImplicitAnimation::timeToNextService, too? > > That method has the same logic for early return. Good catch! I will check if that is needed. Created attachment 383322 [details]
Patch
(In reply to Brent Fulgham from comment #2) > Comment on attachment 383222 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=383222&action=review > > > Source/WebCore/page/animation/KeyframeAnimation.cpp:522 > > +#endif > > Do we need this for ImplicitAnimation::timeToNextService, too? Fixed. Thanks for reviewing! Comment on attachment 383322 [details] Patch Clearing flags on attachment: 383322 Committed r252352: <https://trac.webkit.org/changeset/252352> > Committed r252352: <https://trac.webkit.org/changeset/252352>
Did you meant to close the bug as well?
(In reply to Aakash Jain from comment #8) > > Committed r252352: <https://trac.webkit.org/changeset/252352> > Did you meant to close the bug as well? Yes, thanks! |