Bug 204000

Summary: Many legacy animation tests are timing out with VS2019
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: Tools / TestsAssignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, bfulgham, commit-queue, dino, dstockwell, ews-watchlist, Hironori.Fujii, simon.fraser, tsavell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 197288    
Attachments:
Description Flags
Patch
bfulgham: review+
Patch none

Per Arne Vollan
Reported 2019-11-08 08:07:54 PST
When building WebKit with VS2019, many legacy animation tests are timing out.
Attachments
Patch (1.63 KB, patch)
2019-11-09 10:21 PST, Per Arne Vollan 		bfulgham: review+
DetailsFormatted DiffDiff
Patch (2.43 KB, patch)
2019-11-11 17:13 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2019-11-09 10:21:37 PST
Created attachment 383222 [details] Patch
Brent Fulgham
Comment 2 2019-11-11 14:24:26 PST
Comment on attachment 383222 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383222&action=review > Source/WebCore/page/animation/KeyframeAnimation.cpp:522 > +#endif Do we need this for ImplicitAnimation::timeToNextService, too?
Brent Fulgham
Comment 3 2019-11-11 14:32:02 PST
Comment on attachment 383222 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383222&action=review >> Source/WebCore/page/animation/KeyframeAnimation.cpp:522 >> +#endif > > Do we need this for ImplicitAnimation::timeToNextService, too? That method has the same logic for early return.
Per Arne Vollan
Comment 4 2019-11-11 14:34:59 PST
(In reply to Brent Fulgham from comment #3) > Comment on attachment 383222 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=383222&action=review > > >> Source/WebCore/page/animation/KeyframeAnimation.cpp:522 > >> +#endif > > > > Do we need this for ImplicitAnimation::timeToNextService, too? > > That method has the same logic for early return. Good catch! I will check if that is needed.
Per Arne Vollan
Comment 5 2019-11-11 17:13:38 PST
Created attachment 383322 [details] Patch
Per Arne Vollan
Comment 6 2019-11-11 17:14:35 PST
(In reply to Brent Fulgham from comment #2) > Comment on attachment 383222 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=383222&action=review > > > Source/WebCore/page/animation/KeyframeAnimation.cpp:522 > > +#endif > > Do we need this for ImplicitAnimation::timeToNextService, too? Fixed. Thanks for reviewing!
WebKit Commit Bot
Comment 7 2019-11-11 17:58:59 PST
Comment on attachment 383322 [details] Patch Clearing flags on attachment: 383322 Committed r252352: <https://trac.webkit.org/changeset/252352>
Aakash Jain
Comment 8 2019-11-12 06:33:15 PST
> Committed r252352: <https://trac.webkit.org/changeset/252352> Did you meant to close the bug as well?
Per Arne Vollan
Comment 9 2019-11-12 10:53:33 PST
(In reply to Aakash Jain from comment #8) > > Committed r252352: <https://trac.webkit.org/changeset/252352> > Did you meant to close the bug as well? Yes, thanks!
Radar WebKit Bug Importer
Comment 10 2019-11-12 10:54:16 PST
<rdar://problem/57122380>
Note You need to log in before you can comment on or make changes to this bug.