| Summary: | Enable GPU switching with ANGLE | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | James Darpinian <jdarpinian> | ||||||||||
| Component: | ANGLE | Assignee: | Nobody <webkit-unassigned> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | achristensen, commit-queue, dino, ews-watchlist, graouts, justin_fan, kondapallykalyan, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Bug Depends on: | |||||||||||||
| Bug Blocks: | 198948 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
James Darpinian
2019-11-06 13:21:11 PST
Created attachment 382953 [details]
Enable GPU switching with ANGLE
Created attachment 382959 [details]
Fix build error
Comment on attachment 382959 [details] Fix build error View in context: https://bugs.webkit.org/attachment.cgi?id=382959&action=review > Source/WebCore/platform/graphics/GraphicsContext3D.h:1195 > +#if USE(OPENGL) || USE(ANGLE) Did you intentionally drop the PLATFORM(MAC)? Does this work on iOS, too? Also EWS says this needs rebasing. Does it? Created attachment 383676 [details]
Rebase on Dean's ANGLE/iOS changes
Comment on attachment 382959 [details] Fix build error View in context: https://bugs.webkit.org/attachment.cgi?id=382959&action=review >> Source/WebCore/platform/graphics/GraphicsContext3D.h:1195 >> +#if USE(OPENGL) || USE(ANGLE) > > Did you intentionally drop the PLATFORM(MAC)? Does this work on iOS, too? > Also EWS says this needs rebasing. Does it? It didn't work on iOS before, but this was before Dean landed his patches for ANGLE iOS support. I've rebased this and it should work now. Created attachment 384213 [details]
Rebase again
Comment on attachment 384213 [details] Rebase again Clearing flags on attachment: 384213 Committed r252909: <https://trac.webkit.org/changeset/252909> All reviewed patches have been landed. Closing bug. |