Bug 203903 – All EWS status-bubbles shows #1 on security patches when patch is uploaded with webkit-patch --no-review

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Aakash Jain]

All EWS status-bubbles shows #1 on security patches when patch is uploaded with webkit-patch --no-review (but without --no-ews).

This is because in absence of --no-ews flag, the patch is submitted to EWS. However without r? flag, [e-mail] is not cc'ed on the bug, without which EWS can't access the bug. Therefore ews-app tries to fetch the patch and fails. However, in the process it incorrectly set the flag 'sent_to_buildbot' as true, and it thinks that patch has been sent to buildbot, and tries to calculate the patch position in queue (this position will become #1 in some time). 

However, since EWS thinks the patch has been sent to buildbot, it wouldn't display the 'Submit to new ews' button anymore, and keep showing incorrect status-bubbles.

[Aakash Jain]

Created attachment 382931 [details]
Patch

[Aakash Jain]

Logs from Patch 382899 in Bug 203880:

2019-11-06 00:40:18,419 - SubmitToEWS::patch: 382899
2019-11-06 00:40:18,439 - Saved patch in database, id: 382899
2019-11-06 00:40:18,442 - 1 r? patches, 1 patches need to be sent to Buildbot: [382899]
2019-11-06 00:40:18,442 - Sending patch 382899 to buildbot.
2019-11-06 00:40:18,452 - Updated patch 382899 with sent_to_buildbot=True
2019-11-06 00:40:18,568 - Accessed https://bugs.webkit.org/rest/bug/attachment/382899 with unexpected status code 401.
2019-11-06 00:40:18,568 - Unable to fetch attachment "382899".
2019-11-06 00:40:18,568 - Unable to retrive patch "382899"

[Aakash Jain]

This is a small fallout from recent change in https://trac.webkit.org/changeset/251516/webkit

[David Kilzer (:ddkilzer)]

Comment on attachment 382931 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 382931 [details]
Patch

Rejecting attachment 382931 [details] from commit-queue.

New failing tests:
webgl/1.0.3/conformance/extensions/webgl-draw-buffers.html
Full output: https://webkit-queues.webkit.org/results/13219927

[WebKit Commit Bot]

Created attachment 382955 [details]
Archive of layout-test-results from webkit-cq-01 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-01  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[Aakash Jain]

Comment on attachment 382931 [details]
Patch

Clearing flags on attachment: 382931

Committed r252150: <https://trac.webkit.org/changeset/252150>

[Aakash Jain]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/56958629>