Summary: | [GTK] Add pointer lock permission request API | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | annulen, aperez, berto, bugs-noreply, clopez, ews-watchlist, gustavo, gyuyoung.kim, ryuan.choi, sergio | ||||
Priority: | P2 | Keywords: | Gtk | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Carlos Garcia Campos
2019-11-06 05:22:52 PST
Created attachment 382921 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Comment on attachment 382921 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382921&action=review > Source/WebKit/UIProcess/API/gtk/WebKitPointerLockPermissionRequest.h:37 > +#define WEBKIT_TYPE_POINTER_LOCK_PERMISSION_REQUEST (webkit_pointer_lock_permission_request_get_type()) > +#define WEBKIT_POINTER_LOCK_PERMISSION_REQUEST(obj) (G_TYPE_CHECK_INSTANCE_CAST((obj), WEBKIT_TYPE_POINTER_LOCK_PERMISSION_REQUEST, WebKitPointerLockPermissionRequest)) > +#define WEBKIT_POINTER_LOCK_PERMISSION_REQUEST_CLASS(klass) (G_TYPE_CHECK_CLASS_CAST((klass), WEBKIT_TYPE_POINTER_LOCK_PERMISSION_REQUEST, WebKitPointerLockPermissionRequestClass)) > +#define WEBKIT_IS_POINTER_LOCK_PERMISSION_REQUEST(obj) (G_TYPE_CHECK_INSTANCE_TYPE((obj), WEBKIT_TYPE_POINTER_LOCK_PERMISSION_REQUEST)) > +#define WEBKIT_IS_POINTER_LOCK_PERMISSION_REQUEST_CLASS(klass) (G_TYPE_CHECK_CLASS_TYPE((klass), WEBKIT_TYPE_POINTER_LOCK_PERMISSION_REQUEST)) > +#define WEBKIT_POINTER_LOCK_PERMISSION_REQUEST_GET_CLASS(obj) (G_TYPE_INSTANCE_GET_CLASS((obj), WEBKIT_TYPE_POINTER_LOCK_PERMISSION_REQUEST, WebKitPointerLockPermissionRequestClass)) Isn't missing to add WebKitPointerLockPermissionRequest to WebKitAutocleanups.h? Yes, I always forget to add the autocleanups. (In reply to Carlos Garcia Campos from comment #4) > Yes, I always forget to add the autocleanups. Ok. r=me once added the autocleanups. It still needs another review to land since it adds new public API. Comment on attachment 382921 [details]
Patch
LGTM, please remember to add the autocleanup as suggested by
Carlos López before landing. Thanks!
Committed r252234: <https://trac.webkit.org/changeset/252234> |