Bug 203896

Summary:

[GTK] Add pointer lock permission request API

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

annulen, aperez, berto, bugs-noreply, clopez, ews-watchlist, gustavo, gyuyoung.kim, ryuan.choi, sergio

Priority:

Keywords:

Gtk

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	aperez: review+

Carlos Garcia Campos

Reported 2019-11-06 05:22:52 PST

Now that we have pointer lock support, we should provide API to be able to deny a pointer lock request or notify the user before locking the pointer.

Attachments
Patch (26.30 KB, patch) 2019-11-06 05:25 PST, Carlos Garcia Campos	aperez: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Carlos Garcia Campos

Comment 1 2019-11-06 05:25:15 PST

Created attachment 382921 [details] Patch

EWS Watchlist

Comment 2 2019-11-06 05:26:05 PST

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

Carlos Alberto Lopez Perez

Comment 3 2019-11-06 08:45:27 PST

Comment on attachment 382921 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382921&action=review > Source/WebKit/UIProcess/API/gtk/WebKitPointerLockPermissionRequest.h:37 > +#define WEBKIT_TYPE_POINTER_LOCK_PERMISSION_REQUEST (webkit_pointer_lock_permission_request_get_type()) > +#define WEBKIT_POINTER_LOCK_PERMISSION_REQUEST(obj) (G_TYPE_CHECK_INSTANCE_CAST((obj), WEBKIT_TYPE_POINTER_LOCK_PERMISSION_REQUEST, WebKitPointerLockPermissionRequest)) > +#define WEBKIT_POINTER_LOCK_PERMISSION_REQUEST_CLASS(klass) (G_TYPE_CHECK_CLASS_CAST((klass), WEBKIT_TYPE_POINTER_LOCK_PERMISSION_REQUEST, WebKitPointerLockPermissionRequestClass)) > +#define WEBKIT_IS_POINTER_LOCK_PERMISSION_REQUEST(obj) (G_TYPE_CHECK_INSTANCE_TYPE((obj), WEBKIT_TYPE_POINTER_LOCK_PERMISSION_REQUEST)) > +#define WEBKIT_IS_POINTER_LOCK_PERMISSION_REQUEST_CLASS(klass) (G_TYPE_CHECK_CLASS_TYPE((klass), WEBKIT_TYPE_POINTER_LOCK_PERMISSION_REQUEST)) > +#define WEBKIT_POINTER_LOCK_PERMISSION_REQUEST_GET_CLASS(obj) (G_TYPE_INSTANCE_GET_CLASS((obj), WEBKIT_TYPE_POINTER_LOCK_PERMISSION_REQUEST, WebKitPointerLockPermissionRequestClass)) Isn't missing to add WebKitPointerLockPermissionRequest to WebKitAutocleanups.h?

Carlos Garcia Campos

Comment 4 2019-11-07 00:26:19 PST

Yes, I always forget to add the autocleanups.

Carlos Alberto Lopez Perez

Comment 5 2019-11-07 03:08:23 PST

(In reply to Carlos Garcia Campos from comment #4) > Yes, I always forget to add the autocleanups. Ok. r=me once added the autocleanups. It still needs another review to land since it adds new public API.

Adrian Perez

Comment 6 2019-11-07 05:40:56 PST

Comment on attachment 382921 [details] Patch LGTM, please remember to add the autocleanup as suggested by Carlos López before landing. Thanks!

Carlos Garcia Campos

Comment 7 2019-11-08 01:19:09 PST

Committed r252234: <https://trac.webkit.org/changeset/252234>

Note You need to log in before you can comment on or make changes to this bug.