Bug 203874

Summary: Support CSS Dark Mode for PrettyDiff.rb
Product: WebKit Reporter: James Savage <james.savage>
Component: Tools / TestsAssignee: James Savage <james.savage>
Status: RESOLVED FIXED    
Severity: Minor CC: aakash_jain, commit-queue, thorton, timothy, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Example of patch in dark mode
none
Corresponding patch in light mode today
none
Archive of layout-test-results from webkit-cq-03 for mac-highsierra none

James Savage
Reported 2019-11-05 17:54:33 PST
Adopt dark mode for web content.
Attachments
Patch (6.96 KB, patch)
2019-11-05 18:03 PST, James Savage 		no flags
DetailsFormatted DiffDiff
Example of patch in dark mode (993.57 KB, image/png)
2019-11-05 18:03 PST, James Savage 		no flags
Details
Corresponding patch in light mode today (965.63 KB, image/png)
2019-11-05 18:04 PST, James Savage 		no flags
Details
Archive of layout-test-results from webkit-cq-03 for mac-highsierra (3.37 MB, application/zip)
2019-11-06 16:29 PST, WebKit Commit Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
James Savage
Comment 1 2019-11-05 18:03:07 PST
Created attachment 382874 [details] Patch
James Savage
Comment 2 2019-11-05 18:03:53 PST
Created attachment 382875 [details] Example of patch in dark mode
James Savage
Comment 3 2019-11-05 18:04:13 PST
Created attachment 382876 [details] Corresponding patch in light mode today
Tim Horton
Comment 4 2019-11-06 14:47:17 PST
Comment on attachment 382874 [details] Patch This is more of a rubber-stamp
James Savage
Comment 5 2019-11-06 14:54:38 PST
I tested this against bugs.webkit.org by swapping out the CSS via Web Inspector and making sure that everything looked good on a live page too.
WebKit Commit Bot
Comment 6 2019-11-06 16:29:22 PST
Comment on attachment 382874 [details] Patch Rejecting attachment 382874 [details] from commit-queue. New failing tests: webgl/1.0.3/conformance/extensions/webgl-draw-buffers.html Full output: https://webkit-queues.webkit.org/results/13220493
WebKit Commit Bot
Comment 7 2019-11-06 16:29:23 PST
Created attachment 382979 [details] Archive of layout-test-results from webkit-cq-03 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: webkit-cq-03 Port: mac-highsierra Platform: Mac OS X 10.13.6
James Savage
Comment 8 2019-11-06 16:50:29 PST
Unless that test is based on output from show-pretty-diff, I can't imagine the failure being related.
WebKit Commit Bot
Comment 9 2019-11-06 18:42:55 PST
Comment on attachment 382874 [details] Patch Clearing flags on attachment: 382874 Committed r252167: <https://trac.webkit.org/changeset/252167>
WebKit Commit Bot
Comment 10 2019-11-06 18:42:57 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 11 2019-11-06 18:43:18 PST
<rdar://problem/56968427>
Note You need to log in before you can comment on or make changes to this bug.