| Summary: | Support CSS Dark Mode for PrettyDiff.rb | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | James Savage <james.savage> | ||||||||||
| Component: | Tools / Tests | Assignee: | James Savage <james.savage> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Minor | CC: | aakash_jain, commit-queue, thorton, timothy, webkit-bug-importer, wenson_hsieh | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
James Savage
2019-11-05 17:54:33 PST
Created attachment 382874 [details]
Patch
Created attachment 382875 [details]
Example of patch in dark mode
Created attachment 382876 [details]
Corresponding patch in light mode today
Comment on attachment 382874 [details]
Patch
This is more of a rubber-stamp
I tested this against bugs.webkit.org by swapping out the CSS via Web Inspector and making sure that everything looked good on a live page too. Comment on attachment 382874 [details] Patch Rejecting attachment 382874 [details] from commit-queue. New failing tests: webgl/1.0.3/conformance/extensions/webgl-draw-buffers.html Full output: https://webkit-queues.webkit.org/results/13220493 Created attachment 382979 [details]
Archive of layout-test-results from webkit-cq-03 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-03 Port: mac-highsierra Platform: Mac OS X 10.13.6
Unless that test is based on output from show-pretty-diff, I can't imagine the failure being related. Comment on attachment 382874 [details] Patch Clearing flags on attachment: 382874 Committed r252167: <https://trac.webkit.org/changeset/252167> All reviewed patches have been landed. Closing bug. |