Summary: | REGRESSION(r252031): layout tests fail to run in non apple ports after r252031 | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||||||
Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | aakash_jain, commit-queue, ews-watchlist, glenn, jbedard, tsavell, webkit-bug-importer, zan | ||||||||
Priority: | P2 | Keywords: | InRadar, Regression | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=183422 | ||||||||||
Attachments: |
|
Description
Carlos Garcia Campos
2019-11-05 01:19:27 PST
Created attachment 382812 [details]
Patch
Comment on attachment 382812 [details] Patch Clearing flags on attachment: 382812 Committed r252050: <https://trac.webkit.org/changeset/252050> All reviewed patches have been landed. Closing bug. It looks like this patch https://trac.webkit.org/changeset/252050/webkit broke windows testing: https://build.webkit.org/builders/Apple%20Win%2010%20Release%20%28Tests%29/builds/3869 Can this be looked at quickly? Reopening to attach new patch. Created attachment 382840 [details]
Patch
Don't have a windows machine on hand, but the stack trace is pretty explicit. rs=me Created attachment 382851 [details]
Patch for landing
Comment on attachment 382851 [details] Patch for landing Clearing flags on attachment: 382851 Committed r252087: <https://trac.webkit.org/changeset/252087> All reviewed patches have been landed. Closing bug. |