Bug 203773

Summary: Enable powerPreference controlled GPU switching with ANGLE
Product: WebKit Reporter: James Darpinian <jdarpinian>
Component: ANGLEAssignee: James Darpinian <jdarpinian>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, dino, ews-watchlist, graouts, justin_fan, kbr, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 198948    
Attachments:
Description Flags
Enable powerPreference controlled GPU switching with ANGLE
none
Update ChangeLog
none
Update ChangeLog none

James Darpinian
Reported 2019-11-01 17:30:08 PDT
Enable powerPreference controlled GPU switching with ANGLE
Attachments
Enable powerPreference controlled GPU switching with ANGLE (6.07 KB, patch)
2019-11-01 17:32 PDT, James Darpinian 		no flags
DetailsFormatted DiffDiff
Update ChangeLog (6.18 KB, patch)
2019-11-01 17:36 PDT, James Darpinian 		no flags
DetailsFormatted DiffDiff
Update ChangeLog (6.22 KB, patch)
2019-11-04 16:05 PST, James Darpinian 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
James Darpinian
Comment 1 2019-11-01 17:32:46 PDT
Created attachment 382661 [details] Enable powerPreference controlled GPU switching with ANGLE
James Darpinian
Comment 2 2019-11-01 17:36:09 PDT
Created attachment 382662 [details] Update ChangeLog
WebKit Commit Bot
Comment 3 2019-11-04 06:03:52 PST
Comment on attachment 382662 [details] Update ChangeLog Rejecting attachment 382662 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 382662, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: https://webkit-queues.webkit.org/results/13210454
James Darpinian
Comment 4 2019-11-04 15:56:43 PST
Hmm, is there something I should do to fix the commit queue error? I thought the reviewer was automatically added to the ChangeLog somehow.
James Darpinian
Comment 5 2019-11-04 16:05:56 PST
Created attachment 382782 [details] Update ChangeLog
James Darpinian
Comment 6 2019-11-04 16:06:48 PST
I'm guessing it was the fact that I accidentally deleted the "Reviewed by NOBODY" line in my changelog.
WebKit Commit Bot
Comment 7 2019-11-05 08:52:38 PST
Comment on attachment 382782 [details] Update ChangeLog Clearing flags on attachment: 382782 Committed r252055: <https://trac.webkit.org/changeset/252055>
WebKit Commit Bot
Comment 8 2019-11-05 08:52:40 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2019-11-05 08:53:16 PST
<rdar://problem/56905532>
Note You need to log in before you can comment on or make changes to this bug.