| Summary: | Enable powerPreference controlled GPU switching with ANGLE | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | James Darpinian <jdarpinian> | ||||||||
| Component: | ANGLE | Assignee: | James Darpinian <jdarpinian> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | achristensen, commit-queue, dino, ews-watchlist, graouts, justin_fan, kbr, kondapallykalyan, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 198948 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
James Darpinian
2019-11-01 17:30:08 PDT
Created attachment 382661 [details]
Enable powerPreference controlled GPU switching with ANGLE
Created attachment 382662 [details]
Update ChangeLog
Comment on attachment 382662 [details] Update ChangeLog Rejecting attachment 382662 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 382662, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: https://webkit-queues.webkit.org/results/13210454 Hmm, is there something I should do to fix the commit queue error? I thought the reviewer was automatically added to the ChangeLog somehow. Created attachment 382782 [details]
Update ChangeLog
I'm guessing it was the fact that I accidentally deleted the "Reviewed by NOBODY" line in my changelog. Comment on attachment 382782 [details] Update ChangeLog Clearing flags on attachment: 382782 Committed r252055: <https://trac.webkit.org/changeset/252055> All reviewed patches have been landed. Closing bug. |