Bug 203762

Summary: Python 3: Add support in webkitpy.style
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, commit-queue, ews-watchlist, glenn, slewis, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=203761
https://bugs.webkit.org/show_bug.cgi?id=184986
https://bugs.webkit.org/show_bug.cgi?id=204133
Attachments:
Description Flags
Patch
none
Patch none

Jonathan Bedard
Reported 2019-11-01 14:42:57 PDT
Our style checker should support Python 3.
Attachments
Patch (13.31 KB, patch)
2019-11-14 08:11 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (16.33 KB, patch)
2019-11-14 11:12 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2019-11-14 08:11:12 PST
Created attachment 383556 [details] Patch
Jonathan Bedard
Comment 2 2019-11-14 11:12:09 PST
Created attachment 383561 [details] Patch
Jonathan Bedard
Comment 3 2019-11-14 11:13:52 PST
This patch lets us run check-webkit-style with Python 3, via: python3 Tools/Scripts/check-webkit-style Not changing the shebang, but on systems where python maps to Python 3, check-webkit-style should work once this lands.
WebKit Commit Bot
Comment 4 2019-11-14 16:17:04 PST
Comment on attachment 383561 [details] Patch Clearing flags on attachment: 383561 Committed r252468: <https://trac.webkit.org/changeset/252468>
WebKit Commit Bot
Comment 5 2019-11-14 16:17:06 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-11-14 16:18:19 PST
<rdar://problem/57209242>
Note You need to log in before you can comment on or make changes to this bug.