Bug 203729

Summary: Style::Builder should not depend on StyleResolver
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, cdumez, commit-queue, dbates, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, mifenton, tkent, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
wip
none
patch
none
patch
none
patch none

Antti Koivisto
Reported 2019-11-01 04:19:39 PDT
With all style building state is in builder, we can remove the back-reference to style resolver.
Attachments
wip (34.52 KB, patch)
2019-11-01 04:39 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (43.02 KB, patch)
2019-11-01 05:54 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (43.04 KB, patch)
2019-11-01 05:58 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (43.53 KB, patch)
2019-11-01 07:13 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2019-11-01 04:39:56 PDT
Created attachment 382571 [details] wip
Antti Koivisto
Comment 2 2019-11-01 05:54:03 PDT
Created attachment 382572 [details] patch
Antti Koivisto
Comment 3 2019-11-01 05:58:50 PDT
Created attachment 382573 [details] patch
Antti Koivisto
Comment 4 2019-11-01 07:13:26 PDT
Created attachment 382574 [details] patch
WebKit Commit Bot
Comment 5 2019-11-01 08:20:26 PDT
Comment on attachment 382574 [details] patch Clearing flags on attachment: 382574 Committed r251916: <https://trac.webkit.org/changeset/251916>
WebKit Commit Bot
Comment 6 2019-11-01 08:20:28 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-11-01 08:21:21 PDT
<rdar://problem/56816451>
Note You need to log in before you can comment on or make changes to this bug.