Bug 203717 – Make AXIsolatedTreeNode a subclass of AXCoreObject.

• Component: New Bugs
• Status: RESOLVED FIXED

[Andres Gonzalez]

Make AXIsolatedTreeNode a subclass of AXCoreObject.

[Andres Gonzalez]

Created attachment 382543 [details]
Patch

[Andres Gonzalez]

Created attachment 382588 [details]
Patch

[Andres Gonzalez]

GTK and Win changes.

[chris fleizach]

../../Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceAction.cpp: In function ‘WebCore::AccessibilityObject* core(AtkAction*)’:
../../Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceAction.cpp:49:12: error: invalid conversion from ‘WebCore::AXCoreObject*’ to ‘WebCore::AccessibilityObject*’ [-fpermissive]

[Andres Gonzalez]

Created attachment 382609 [details]
Patch

[chris fleizach]

Comment on attachment 382609 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382609&action=review

> Source/WebCore/accessibility/isolatedtree/AXIsolatedTreeNode.h:60
> +    bool isAccessibilityObject() const override { return false; }

can all these methods below here be private?

[Andres Gonzalez]

(In reply to chris fleizach from comment #6)
> Comment on attachment 382609 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=382609&action=review
> 
> > Source/WebCore/accessibility/isolatedtree/AXIsolatedTreeNode.h:60
> > +    bool isAccessibilityObject() const override { return false; }
> 
> can all these methods below here be private?

They are public in the AXCoreObject base class, so what would making them private get us?

[chris fleizach]

(In reply to Andres Gonzalez from comment #7)
> (In reply to chris fleizach from comment #6)
> > Comment on attachment 382609 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=382609&action=review
> > 
> > > Source/WebCore/accessibility/isolatedtree/AXIsolatedTreeNode.h:60
> > > +    bool isAccessibilityObject() const override { return false; }
> > 
> > can all these methods below here be private?
> 
> They are public in the AXCoreObject base class, so what would making them
> private get us?

Most people using this are not supposed to have a handle on the AXIsolateTreeNode object. they're supposed to assume it's a AXCoreObject. if we make those private then they will be forced into using the AXCoreObject rather than one instance over the other

[Andres Gonzalez]

Created attachment 382654 [details]
Patch

[Andres Gonzalez]

(In reply to chris fleizach from comment #8)
> (In reply to Andres Gonzalez from comment #7)
> > (In reply to chris fleizach from comment #6)
> > > Comment on attachment 382609 [details]
> > > Patch
> > > 
> > > View in context:
> > > https://bugs.webkit.org/attachment.cgi?id=382609&action=review
> > > 
> > > > Source/WebCore/accessibility/isolatedtree/AXIsolatedTreeNode.h:60
> > > > +    bool isAccessibilityObject() const override { return false; }
> > > 
> > > can all these methods below here be private?
> > 
> > They are public in the AXCoreObject base class, so what would making them
> > private get us?
> 
> Most people using this are not supposed to have a handle on the
> AXIsolateTreeNode object. they're supposed to assume it's a AXCoreObject. if
> we make those private then they will be forced into using the AXCoreObject
> rather than one instance over the other

Done. Thanks.

[EWS]

Comment on attachment 382654 [details]
Patch

Rejecting attachment 382654 [details] from commit-queue.

[e-mail] does not have committer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[EWS]

Comment on attachment 382654 [details]
Patch

Rejecting attachment 382654 [details] from commit-queue.

[e-mail] does not have committer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[WebKit Commit Bot]

Comment on attachment 382654 [details]
Patch

Clearing flags on attachment: 382654

Committed r251974: <https://trac.webkit.org/changeset/251974>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/56849760>