Bug 203711

Summary: SVGAnimatedNumber should throw a TypeError exception when setting its baseVal to NaN or Infinity
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: SVGAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: ahmad.saleem792, dino, ews-watchlist, fmalita, gyuyoung.kim, pdr, schenney, sergio, zimmermann
Priority: P2 Keywords: WPTImpact
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch sabouhallawa: review?

Said Abou-Hallawa
Reported 2019-10-31 18:12:41 PDT
The specs: https://www.w3.org/TR/SVG/types.html#InterfaceSVGAnimatedNumber do not say that this should happen. But the WPT test https://wpt.fyi/results/svg/types/scripted/SVGAnimatedNumber.html?label=master&label=experimental&aligned expects this to happen. I think throwing an exception and keeping the value unchanged is much better than setting it to NaN.
Attachments
Patch (6.72 KB, patch)
2019-10-31 18:16 PDT, Said Abou-Hallawa 		sabouhallawa: review?
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Said Abou-Hallawa
Comment 1 2019-10-31 18:16:56 PDT
Created attachment 382531 [details] Patch
Ahmad Saleem
Comment 2 2023-01-01 06:22:32 PST
Safari Technology Preview 160 is still failing this test case: https://wpt.fyi/results/svg/types/scripted/SVGAnimatedNumber.html?label=master&label=experimental&aligned&view=subtest&q=svganimatednumber
Ahmad Saleem
Comment 3 2023-05-12 02:33:59 PDT
I progressed this with following Commit - https://github.com/WebKit/WebKit/commit/300c734d4a81735113dc5cfd69d327715a96b883 Do we need this anymore?
Said Abou-Hallawa
Comment 4 2024-09-09 13:32:31 PDT
No. This is not needed. bug 256617 has a better way to fix this issue. *** This bug has been marked as a duplicate of bug 256617 ***
Note You need to log in before you can comment on or make changes to this bug.