Bug 203687 – SVGGeometryElement.getPointAtLength should clamp its argument to [0, length]

• Component: SVG
• Status: RESOLVED FIXED

[Said Abou-Hallawa]

The spec link is: https://svgwg.org/svg2-draft/types.html#__svg__SVGGeometryElement__getPointAtLength

[Said Abou-Hallawa]

Created attachment 382481 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 382481 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382481&action=review

> Source/WebCore/svg/SVGGeometryElement.cpp:64
> +    // Sepc: If current element is a non-rendered element, throw an InvalidStateError.

"Sepc"

> Source/WebCore/svg/SVGGeometryElement.cpp:68
> +    // Sepc: Clamp distance to [0, length].

"Sepc"

> Source/WebCore/svg/SVGGeometryElement.cpp:69
> +    distance = std::min<float>(std::max<float>(distance, 0), getTotalLength());

We have a clampTo() function

> Source/WebCore/svg/SVGGeometryElement.cpp:71
> +    // Sepc: Return a newly created, detached SVGPoint object.

"Sepc"

> Source/WebCore/svg/SVGPathElement.cpp:117
> +    // Sepc: Clamp distance to [0, length].
> +    distance = std::min<float>(std::max<float>(distance, 0), getTotalLength());
> +
> +    // Sepc: Return a newly created, detached SVGPoint object.

Ditto.

[Said Abou-Hallawa]

Created attachment 382493 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 382493 [details]
Patch

Clearing flags on attachment: 382493

Committed r251877: <https://trac.webkit.org/changeset/251877>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/56794713>