Bug 203682 – Introduce Style::Builder

• Component: CSS
• Status: RESOLVED FIXED

[Antti Koivisto]

Add Style::Builder for encapsulating the style building step.

[Antti Koivisto]

Created attachment 382466 [details]
patch

[Antti Koivisto]

Created attachment 382472 [details]
patch

[alan]

Comment on attachment 382472 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382472&action=review

> Source/WebCore/css/StyleResolver.cpp:5
> + * Copyright (C) 2005-2019 Apple Inc. All rights reserved.

I am glad someone picked this file up after 5 years.

[Antti Koivisto]

> I am glad someone picked this file up after 5 years.

The style team is pretty lazy.

[WebKit Commit Bot]

Comment on attachment 382472 [details]
patch

Rejecting attachment 382472 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 382472, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=382472&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=203682&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Updating working directory
Processing patch 382472 from bug 203682.
Fetching: https://bugs.webkit.org/attachment.cgi?id=382472
Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	A	Source/WebCore/style/StyleBuilder.cpp
	A	Source/WebCore/style/StyleBuilder.h
	M	Source/WebCore/ChangeLog
	M	Source/WebCore/DerivedSources-output.xcfilelist
	M	Source/WebCore/Sources.txt
	M	Source/WebCore/WebCore.xcodeproj/project.pbxproj
	M	Source/WebCore/css/CSSVariableReferenceValue.cpp
	M	Source/WebCore/css/DOMCSSRegisterCustomProperty.cpp
	M	Source/WebCore/css/StyleResolver.cpp
	M	Source/WebCore/css/StyleResolver.h
	M	Source/WebCore/css/parser/CSSParser.cpp
	M	Source/WebCore/css/parser/CSSPropertyParser.cpp
	M	Source/WebCore/style/PropertyCascade.cpp
	M	Source/WebCore/style/PropertyCascade.h
	M	Source/WebCore/style/StyleBuilderCustom.h
	M	Source/WebCore/style/StyleBuilderState.cpp
	M	Source/WebCore/style/StyleBuilderState.h

ERROR from SVN:
Merge conflict during commit: Conflict at '/trunk/Source/WebCore/ChangeLog'
W: f4e1f9e226377a9bff246ba55733dd80cb3fb2fe and refs/remotes/origin/master differ, using rebase:
:040000 040000 5b1308f062c595c1de024e569692d2665e164a7c 3e91f97e375693cb2e2438aa06f4939932bf9431 M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	A	Source/WebCore/style/StyleBuilder.cpp
	A	Source/WebCore/style/StyleBuilder.h
	M	Source/WebCore/ChangeLog
	M	Source/WebCore/DerivedSources-output.xcfilelist
	M	Source/WebCore/Sources.txt
	M	Source/WebCore/WebCore.xcodeproj/project.pbxproj
	M	Source/WebCore/css/CSSVariableReferenceValue.cpp
	M	Source/WebCore/css/DOMCSSRegisterCustomProperty.cpp
	M	Source/WebCore/css/StyleResolver.cpp
	M	Source/WebCore/css/StyleResolver.h
	M	Source/WebCore/css/parser/CSSParser.cpp
	M	Source/WebCore/css/parser/CSSPropertyParser.cpp
	M	Source/WebCore/style/PropertyCascade.cpp
	M	Source/WebCore/style/PropertyCascade.h
	M	Source/WebCore/style/StyleBuilderCustom.h
	M	Source/WebCore/style/StyleBuilderState.cpp
	M	Source/WebCore/style/StyleBuilderState.h

ERROR from SVN:
Merge conflict during commit: Conflict at '/trunk/Source/WebCore/ChangeLog'
W: f4e1f9e226377a9bff246ba55733dd80cb3fb2fe and refs/remotes/origin/master differ, using rebase:
:040000 040000 5b1308f062c595c1de024e569692d2665e164a7c 3e91f97e375693cb2e2438aa06f4939932bf9431 M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
From https://git.webkit.org/git/WebKit
   4949bf8b789..b6952eda3ca  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 251856 = 4949bf8b789c33394ca4d50d3452d466adaaf48a
r251857 = 5e6df0b6f14bd6b9fc5469ac9f1a0392ae4f8c85
r251858 = 0c9b8a9a3cc8a7870e954181755f5c0d89bc61d9
r251859 = 3329bcd4ec8e95f54f4e8918a194dc713345ad8b
r251861 = b6952eda3cad2deb6746c04969f57a9370198c4f
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: https://webkit-queues.webkit.org/results/13196156

[Antti Koivisto]

Created attachment 382479 [details]
patch

[WebKit Commit Bot]

Comment on attachment 382479 [details]
patch

Clearing flags on attachment: 382479

Committed r251864: <https://trac.webkit.org/changeset/251864>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/56790051>