Bug 203672

Summary:

[CMake] TestWebCore shouldn't link with WebCoreTestSupport

Product:

WebKit

Reporter:

Fujii Hironori <fujii.hironori>

Component:

CMake

Assignee:

Fujii Hironori <fujii.hironori>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

annulen, bugs-noreply, commit-queue, don.olmstead, ews-watchlist, gyuyoung.kim, mcatanzaro, ryuan.choi, sergio

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Fujii Hironori

Reported 2019-10-31 03:27:33 PDT

[CMake] TestWebCore shouldn't link with WebCoreTestSupport TestWebCore doesn't need to link with WebCoreTestSupport. And, it causes a problem for Windows because WebCoreTestSupport imports WebCore symbols by using dllimport, however, WebCore is not a DLL. (Bug 203663 Comment 4)

Attachments
Patch (4.41 KB, patch) 2019-10-31 03:53 PDT, Fujii Hironori	no flags	Details Formatted Diff Diff
Patch (1.59 KB, patch) 2019-10-31 22:28 PDT, Fujii Hironori	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Fujii Hironori

Comment 1 2019-10-31 03:53:50 PDT

Created attachment 382446 [details] Patch

Fujii Hironori

Comment 2 2019-10-31 05:00:36 PDT

Comment on attachment 382446 [details] Patch wincairo ews can't compile DumpRenderTreeLib. > FAILED: Tools/DumpRenderTree/CMakeFiles/DumpRenderTreeLib.dir/WorkQueue.cpp.obj > C:\MSVS\VC\Tools\MSVC\14.23.28105\bin\Hostx64\x64\cl.exe /nologo /TP -DBUILDING_WITH_CMAKE=1 -DDumpRenderTreeLib_EXPORTS -DHAVE_CONFIG_H=1 -DNOCRYPT -DNOMINMAX -DUNICODE -DUSE_CONSOLE_ENTRY_POINT -DWINVER=0x601 -DWIN_CAIRO -DWTF_PLATFORM_WIN_CAIRO=1 -D_CRT_SECURE_CPP_OVERLOAD_STANDARD_NAMES=1 -D_CRT_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_UNICODE -D_WIN32_WINNT=0x601 -D_WINDOWS -D_WINSOCKAPI_="" -IWebCore\PrivateHeaders -IWebKitLegacy\Headers -IDerivedSources\DumpRenderTree -I..\..\Tools\TestRunnerShared\UIScriptContext -I..\..\Tools\TestRunnerShared\Bindings -I..\..\Tools\DumpRenderTree -I..\..\Source -I..\..\Source\WebCore\testing\js -I..\..\Tools\DumpRenderTree\win -I..\..\Tools\DumpRenderTree\TestNetscapePlugIn -I..\..\Tools\DumpRenderTree\TestNetscapePlugIn\ForwardingHeaders -I..\..\Tools\DumpRenderTree\TestNetscapePlugIn\Tests -I..\..\Tools\DumpRenderTree\TestNetscapePlugIn\win -I..\..\Tools\DumpRenderTree\TestNetscapePlugIn\Tests\win -I..\..\Tools\DumpRenderTree\cairo -I..\..\WebKitLibraries\win\include\cairo -IJavaScriptCore\Headers -IJavaScriptCore\PrivateHeaders -IWTF\Headers -I. -IDerivedSources -I..\..\Source\ThirdParty -I..\..\WebKitLibraries\win\include /W4 /DWIN32 /D_WINDOWS /GR- /EHs- /EHc- /MD /O2 /Ob2 /DNDEBUG /wd4018 /wd4068 /wd4099 /wd4100 /wd4127 /wd4138 /wd4146 /wd4180 /wd4189 /wd4201 /wd4206 /wd4244 /wd4251 /wd4267 /wd4275 /wd4288 /wd4291 /wd4305 /wd4309 /wd4344 /wd4355 /wd4389 /wd4396 /wd4456 /wd4457 /wd4458 /wd4459 /wd4481 /wd4503 /wd4505 /wd4510 /wd4512 /wd4530 /wd4610 /wd4611 /wd4646 /wd4702 /wd4706 /wd4722 /wd4800 /wd4819 /wd4951 /wd4952 /wd4996 /wd6011 /wd6031 /wd6211 /wd6246 /wd6255 /wd6387 /Zi /GS /EHa- /EHc- /EHs- /fp:except- /analyze- /bigobj /utf-8 /validate-charset /Oy- -std:c++17 /Yu"DumpRenderTreePrefix.h" /FI"DumpRenderTreePrefix.h" /Fp"C:/Buildbot/WinCairo-EWS/build/WebKitBuild/Release/Tools/DumpRenderTree/DumpRenderTreeLib_SOURCES/DumpRenderTreePrefix.pch" /showIncludes /FoTools\DumpRenderTree\CMakeFiles\DumpRenderTreeLib.dir\WorkQueue.cpp.obj /FdTools\DumpRenderTree\CMakeFiles\DumpRenderTreeLib.dir\ /FS -c ..\..\Tools\DumpRenderTree\WorkQueue.cpp > C:\Buildbot\WinCairo-EWS\build\Tools\DumpRenderTree\config.h(27): fatal error C1083: Cannot open include file: 'pal/ExportMacros.h': No such file or directory

Fujii Hironori

Comment 3 2019-10-31 22:28:20 PDT

Created attachment 382560 [details] Patch

WebKit Commit Bot

Comment 4 2019-11-01 07:26:24 PDT

Comment on attachment 382560 [details] Patch Clearing flags on attachment: 382560 Committed r251915: <https://trac.webkit.org/changeset/251915>

WebKit Commit Bot

Comment 5 2019-11-01 07:26:26 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.