Bug 20364 – [XBL] Add shadow tree rendering

• Component: WebCore Misc.
• Status: RESOLVED INVALID

[Julien Chaffraix]

Currently, we do not generate the shadow tree's renderer from <template>'s children.

Patch will follow.

[Julien Chaffraix]

Created attachment 22759 [details]
First try: add rendering code following SVGUseElement example

[Eric Seidel (no email)]

Comment on attachment 22759 [details]
First try: add rendering code following SVGUseElement example

This check looks wrong:
f (templateElement->attached())

tempalteElement is in the xbl doc, no?

this one doens't need braces:
 if (node->hasTagName(XBLNames::templateTag)) {

Otherwise looks fine.

r- for the worng check.  I don't need to see this again, if you can convince me over IRC that you've put the right check in instead of the templateElement thing... well, and I guess you should add a test case too! :)

[Julien Chaffraix]

(In reply to comment #2)
> (From update of attachment 22759 [details] [edit])
> This check looks wrong:
> f (templateElement->attached())
> 
> tempalteElement is in the xbl doc, no?

Yes.

However we cannot say whether it was attached or not, so that's why we need to detach it before reattaching its children at the right place. If we do not do that, we will hit some ASSERT while attaching the children.

> this one doens't need braces:
>  if (node->hasTagName(XBLNames::templateTag)) {

Right (silly mistake on my side which will be corrected before landing).

[Julien Chaffraix]

Eric, could you tell me whether you are ok with the comment and the approach taken?
This only adds the rendering for inline XBL document and will need more thoughts to work when the binding document and the bound document are different.

[Dimitri Glazkov (Google)]

We ripped this code out and a new implementation is under way.